Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix missing translations in inspector — Cross-Sells Block #7616

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Fix missing translations in inspector — Cross-Sells Block #7616

merged 5 commits into from
Nov 17, 2022

Conversation

tarhi-saad
Copy link
Contributor

@tarhi-saad tarhi-saad commented Nov 8, 2022 •
edited
Loading

This PR fixes the missing translations in the inspector (in the Editor mode) of the Cross-Sells Block.

Based on #6737, we can fix this translation issue by registering the Inner Blocks in question server-side. For more information about the why? and how? please read this PR description.

Fixes #7476

Accessibility

Other Checks

  • This PR adds/removes a feature flag & I've updated this doc.
  • This PR adds/removes an experimental interfaces and I've updated this doc.
  • I tagged two reviewers because this PR makes queries to the database or I think it might have some security impact.

Screenshots

Cart Cross-Sells Block

Before After
image image

Cart Cross-Sells Products Block

Before After
image image

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

User Facing Testing

  1. Change your site language (I tested using the Spanish language — Español). Make sure the translation files are updated (Check Dashboard -> updates).
  2. Go to the Cart Block (Editor mode)
  3. Select the Cart Cross-Sell and Cart Cross-Sells products blocks, and make sure the title & description are translated in the inspector. See the image below:

image

  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

Performance Impact

Changelog

Fix missing translations in the inspector (editor mode) for the Cart Cross-Sells Blocks

@tarhi-saad tarhi-saad added type: bug The issue/PR concerns a confirmed bug. focus: blocks Specific work involving or impacting how blocks behave. block: cart Issues related to the cart block. labels Nov 8, 2022
@tarhi-saad tarhi-saad requested a review from nielslange November 8, 2022 16:57
@rubikuserbot rubikuserbot requested a review from a team November 8, 2022 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-7616.zip

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022 •
edited
Loading

TypeScript Errors Report

Files with errors: 431
Total errors: 2069

🎉 🎉 This PR does not introduce new TS errors.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022 •
edited
Loading

Size Change: -46 B (0%)

Total Size: 991 kB

Filename Size Change
build/active-filters.js 7.32 kB -1 B (0%)
build/all-products.js 33.5 kB -4 B (0%)
build/all-reviews.js 7.79 kB +1 B (0%)
build/attribute-filter.js 12.2 kB +2 B (0%)
build/cart-frontend.js 54.5 kB -1 B (0%)
build/cart.js 46.3 kB -32 B (0%)
build/checkout.js 40.3 kB -12 B (0%)
build/featured-category.js 13.2 kB +3 B (0%)
build/featured-product.js 13.4 kB +1 B (0%)
build/filter-wrapper.js 2.41 kB -2 B (0%)
build/handpicked-products.js 7.29 kB +1 B (0%)
build/legacy-template.js 2.85 kB +1 B (0%)
build/mini-cart-contents.js 17.1 kB -1 B (0%)
build/price-filter.js 8.38 kB +4 B (0%)
build/product-add-to-cart.js 8.36 kB -1 B (0%)
build/product-best-sellers.js 7.62 kB -2 B (0%)
build/product-button.js 3.82 kB -2 B (0%)
build/product-categories.js 2.36 kB +1 B (0%)
build/product-category-list.js 503 B +1 B (0%)
build/product-category.js 8.62 kB -3 B (0%)
build/product-image.js 3.92 kB -1 B (0%)
build/product-new.js 7.62 kB -2 B (0%)
build/product-on-sale.js 7.95 kB +1 B (0%)
build/product-sale-badge.js 813 B +1 B (0%)
build/product-search.js 2.61 kB -3 B (0%)
build/product-sku.js 377 B +1 B (0%)
build/product-stock-indicator.js 644 B -2 B (0%)
build/product-summary.js 920 B -1 B (0%)
build/product-tag-list.js 497 B -1 B (0%)
build/product-tag.js 8 kB +3 B (0%)
build/product-title.js 3.3 kB +2 B (0%)
build/product-top-rated.js 7.86 kB -1 B (0%)
build/products-by-attribute.js 8.54 kB +2 B (0%)
build/reviews-by-category.js 11.2 kB -2 B (0%)
build/reviews-by-product.js 12.3 kB -1 B (0%)
build/single-product.js 10 kB -4 B (0%)
build/stock-filter.js 6.7 kB +1 B (0%)
build/wc-blocks-vendors.js 62.4 kB +5 B (0%)
build/wc-blocks.js 2.63 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 7.74 kB
build/active-filters-wrapper-frontend.js 6.02 kB
build/all-products-frontend.js 26.4 kB
build/attribute-filter-frontend.js 22.6 kB
build/attribute-filter-wrapper-frontend.js 7.13 kB
build/blocks-checkout.js 18.5 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.37 kB
build/cart-blocks/cart-cross-sells-frontend.js 253 B
build/cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 5.47 kB
build/cart-blocks/cart-cross-sells-products-frontend.js 4.67 kB
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js 5.01 kB
build/cart-blocks/cart-express-payment-frontend.js 764 B
build/cart-blocks/cart-items-frontend.js 298 B
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.29 kB
build/cart-blocks/cart-line-items-frontend.js 1.07 kB
build/cart-blocks/cart-order-summary-frontend.js 1.11 kB
build/cart-blocks/cart-totals-frontend.js 320 B
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/filled-cart-frontend.js 783 B
build/cart-blocks/order-summary-coupon-form-frontend.js 1.73 kB
build/cart-blocks/order-summary-discount-frontend.js 2.16 kB
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 455 B
build/cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping-frontend.js 5.66 kB
build/cart-blocks/order-summary-shipping-frontend.js 428 B
build/cart-blocks/order-summary-subtotal-frontend.js 273 B
build/cart-blocks/order-summary-taxes-frontend.js 433 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.19 kB
build/checkout-blocks/actions-frontend.js 1.77 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 3.9 kB
build/checkout-blocks/billing-address-frontend.js 952 B
build/checkout-blocks/contact-information-frontend.js 1.77 kB
build/checkout-blocks/express-payment-frontend.js 1.12 kB
build/checkout-blocks/fields-frontend.js 343 B
build/checkout-blocks/order-note-frontend.js 1.14 kB
build/checkout-blocks/order-summary-cart-items-frontend.js 3.67 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 1.89 kB
build/checkout-blocks/order-summary-discount-frontend.js 2.28 kB
build/checkout-blocks/order-summary-fee-frontend.js 275 B
build/checkout-blocks/order-summary-frontend.js 1.11 kB
build/checkout-blocks/order-summary-shipping-frontend.js 603 B
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/order-summary-taxes-frontend.js 433 B
build/checkout-blocks/payment-frontend.js 7.77 kB
build/checkout-blocks/shipping-address-frontend.js 1.06 kB
build/checkout-blocks/shipping-methods-frontend.js 4.89 kB
build/checkout-blocks/terms-frontend.js 1.63 kB
build/checkout-blocks/totals-frontend.js 323 B
build/checkout-frontend.js 56.6 kB
build/filter-wrapper-frontend.js 13.8 kB
build/general-style-rtl.css 1.29 kB
build/general-style.css 1.29 kB
build/mini-cart-component-frontend.js 20 kB
build/mini-cart-contents-block/empty-cart-frontend.js 366 B
build/mini-cart-contents-block/filled-cart-frontend.js 230 B
build/mini-cart-contents-block/footer-frontend.js 2.97 kB
build/mini-cart-contents-block/items-frontend.js 237 B
build/mini-cart-contents-block/products-table-frontend.js 591 B
build/mini-cart-contents-block/shopping-button-frontend.js 288 B
build/mini-cart-contents-block/title-frontend.js 368 B
build/mini-cart-frontend.js 1.77 kB
build/mini-cart.js 4.29 kB
build/price-filter-frontend.js 13.6 kB
build/price-filter-wrapper-frontend.js 7.01 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 226 B
build/product-add-to-cart--product-button--product-image--product-rating--product-title.js 151 B
build/product-add-to-cart-frontend.js 1.25 kB
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 431 B
build/product-button--product-image--product-rating--product-sale-badge--product-title.js 302 B
build/product-button-frontend.js 1.89 kB
build/product-category-list-frontend.js 884 B
build/product-image-frontend.js 1.9 kB
build/product-price-frontend.js 1.92 kB
build/product-price.js 1.53 kB
build/product-query.js 2.89 kB
build/product-rating-frontend.js 1.2 kB
build/product-rating.js 787 B
build/product-sale-badge-frontend.js 1.15 kB
build/product-sku-frontend.js 377 B
build/product-stock-indicator-frontend.js 1.01 kB
build/product-summary-frontend.js 1.29 kB
build/product-tag-list-frontend.js 878 B
build/product-title-frontend.js 1.33 kB
build/rating-filter-frontend.js 7.16 kB
build/rating-filter-wrapper-frontend.js 5.41 kB
build/rating-filter.js 5.79 kB
build/reviews-frontend.js 7.01 kB
build/single-product-frontend.js 32.2 kB
build/stock-filter-frontend.js 7.78 kB
build/stock-filter-wrapper-frontend.js 6.03 kB
build/vendors--attribute-filter-wrapper--mini-cart-contents-block/footer-frontend.js 6.86 kB
build/vendors--attribute-filter-wrapper-frontend.js 8.22 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--671ca56f-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js 19.1 kB
build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 7.53 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.85 kB
build/wc-blocks-data.js 18.5 kB
build/wc-blocks-editor-style-rtl.css 5.24 kB
build/wc-blocks-editor-style.css 5.24 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 931 B
build/wc-blocks-registry.js 2.92 kB
build/wc-blocks-shared-context.js 1.51 kB
build/wc-blocks-shared-hocs.js 1.72 kB
build/wc-blocks-style-rtl.css 24.2 kB
build/wc-blocks-style.css 24.2 kB
build/wc-blocks-vendors-style-rtl.css 1.95 kB
build/wc-blocks-vendors-style.css 1.95 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB

compressed-size-action

@tarhi-saad tarhi-saad added the focus: i18n The issue/PR is related to internationalization. label Nov 8, 2022
nielslange
nielslange approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @tarhi-saad! The PR works like charm. Let's ⛴ it! 🙌

@github-actions github-actions bot added this to the 9.0.0 milestone Nov 14, 2022
@tarhi-saad tarhi-saad merged commit 618e0aa into trunk Nov 17, 2022
@tarhi-saad tarhi-saad deleted the fix/cart-cross-sells-translation branch November 17, 2022 13:41
@senadir senadir mentioned this pull request Dec 7, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielslange nielslange nielslange approved these changes

Assignees
No one assigned
Labels
block: cart Issues related to the cart block. focus: blocks Specific work involving or impacting how blocks behave. focus: i18n The issue/PR is related to internationalization. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Register Cross-sells inner block on the back-end (For translation)
2 participants
@tarhi-saad @nielslange