This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Convert product-elements/price to TypeScript #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
…hub.com:woocommerce/woocommerce-blocks into update/7092-convert-product-element-price-to-TS # Conflicts: # assets/js/atomic/blocks/product-elements/price/edit.tsx
…thub.com:woocommerce/woocommerce-blocks into update/7092-convert-product-elements-price-to-TS # Conflicts: # assets/js/atomic/blocks/product-elements/price/attributes.ts # assets/js/atomic/blocks/product-elements/price/edit.tsx # assets/js/atomic/blocks/product-elements/price/index.ts # checkstyle.xml
nielslange
added
type: enhancement
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 429
assets/js/atomic/blocks/product-elements/image/test/block.test.tsx
assets/js/base/components/formatted-monetary-amount/index.tsx assets/js/blocks/single-product/edit/layout-editor.tsx |
|
Size Change: +175 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
nielslange
commented
Nov 15, 2022
There was a problem hiding this comment.
@wavvves and @imanish003 While solving a merge conflict, I accidentally closed #7534. Would you mind reviewing this updated PR again?
packages/prices/utils/price.ts
Outdated
| @@ -73,7 +73,7 @@ export const getCurrencyFromPriceResponse = ( | |||
| // Currency data object, for example an API response containing currency formatting data. | |||
| currencyData?: | |||
| | CurrencyResponse | |||
| | Record< string, never > | |||
| | Record< string, never | unknown > | |||
There was a problem hiding this comment.
This part had been changed to prevent a TS error related to the prices attribute in the following section:
…thub.com:woocommerce/woocommerce-blocks into update/7092-convert-product-elements-price-to-TS
nielslange
commented
Nov 15, 2022
Comment on lines
+2
to
+3
| productId?: number; | ||
| align?: 'left' | 'center' | 'right'; |
There was a problem hiding this comment.
This part had been changed to prevent a TS error in the following section:
Comment on lines
+2
to
+5
| productId?: number; | ||
| className?: string; | ||
| textAlign?: 'left' | 'center' | 'right'; | ||
| isDescendentOfQueryLoop?: boolean; |
There was a problem hiding this comment.
The attributes are optional to prevent a TS error in the following section:
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
nielslange
removed
the
status: stale
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
status: stale
…to-TS # Conflicts: # assets/js/atomic/blocks/product-elements/price/attributes.ts # assets/js/atomic/blocks/product-elements/price/block.tsx # assets/js/atomic/blocks/product-elements/price/index.ts # assets/js/atomic/blocks/product-elements/sale-badge/types.ts # checkstyle.xml
|
The release ZIP for this PR is accessible via: |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/components/product-price/index.tsx
|
…to-TS # Conflicts: # assets/js/blocks/single-product/block.tsx # assets/js/blocks/single-product/edit/layout-editor.tsx # assets/js/shared/context/product-data-context.tsx # checkstyle.xml
…thub.com:woocommerce/woocommerce-blocks into update/7092-convert-product-elements-price-to-TS
wavvves
approved these changes
Dec 23, 2022
|
Thanks for your double-review, @wavvves! 🙌 |
nielslange
deleted the
update/7092-convert-product-elements-price-to-TS
branch
|
We'll need to revise this, as some of this types are wrong. Too many arguments were made optional, but this causes the component to error out. For example: https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/285218ba2664af06c852a47918f7461d51b76c1f/assets/js/base/components/product-price/index.tsx#L160 You can see TypeScript complains and, in fact, if you try it, the component errors out. Should we add a new issue or reopen the original conversion issue? |
1 task
imanish003
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While solving a merge conflict, I accidentally closed #7534. This is the updated version that solved the previous merge conflict.
Fixes #7092
Currently, the
product-elements/priceis still written in JS and is using prop-types for type checking. This PR aims to convertproduct-elements/priceto TypeScript.Testing
User Facing Testing
Single Product blockto it.Product Price inner blockis still visible.