This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Blockifying Product Archive Templates]: Implement the blockified template conversion for the Classic Template Block. #8248
[Blockifying Product Archive Templates]: Implement the blockified template conversion for the Classic Template Block. #8248
Changes from 46 commits
2fddc21
d5eb4e3
5f95c8d
7b94fc5
a5b2a79
c3bbc70
a185597
e9dee03
6e49f88
e6922a9
012a03f
12d4c62
52d1313
a52107d
b57cc98
610eeda
a203496
b603490
847fb46
c812ba5
bda27ac
88ddb2a
7427a4b
a64835e
36f740b
c2c5657
7f1d2eb
4a4b8e5
f14f657
5505f02
6d8607c
3afd81e
a3b50bd
435b7f4
8a36881
11c587a
cd71a6a
fe5f1a8
adcec0b
31a5d4e
9e2d999
295e601
18dea27
39e6c73
713cc5e
1722726
11a90df
35c8dc1
7f6a438
3ba2516
5819006
f925c7b
72ac96f
462fa4a
e79b6f6
431b78a
a384c13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, it's a bit unclear what
productsBy
means. Can we consider other alternative here? Somethings likeproductTaxonomy
,productLoop
,productGrid
? or even keeparchiveProduct
for shared template, and useproductCatalog
just for the catalog page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for feedback, makes sense! I Changed that to
productTaxonomy
(commit)