This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Provide a way to switch to the blockified Single Product Template #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Product Image Gallery
…ocks into add/8233-product-image-gallery-block
When used in a Row block in a blockified Archive Product template, Product Results Count had additional unnecessary margin which caused misalignment with the Catalog Sorting block
It was added couple of commits earlier, since the template was kept there, but it was decided to move it to assets directory, so entry is no longer necessary
…on the availability to convert to Products block
…in blockified Archive Product template
…ell as Single Product templates
…/woocommerce-blocks into add/convert-classic-template
…ex.tsx to the product-archive.ts
…ed template blocks aligned wide That is required, so the Classic Template layout is preserved
…://github.com/woocommerce/woocommerce-blocks into add/8208-convert-single-product
…://github.com/woocommerce/woocommerce-blocks into add/8208-convert-single-product
…://github.com/woocommerce/woocommerce-blocks into add/8208-convert-single-product
…ocks into add/8208-convert-single-product
gigitux
removed
the
status: blocked
|
The PR is ready to be reviewed! @thealexandrelara @kmanijak |
There was a problem hiding this comment.
I have some points that I'd like to discuss before approving:
-
I noticed that the Related Products block does not have the title for the section, and probably this is happening because a
wp-block-headingblock is missing before the Related Products block.
-
I also noticed that the Product Details and the Related Products blocks have a smaller width than the blocks above. The classic template for the Single Product block had a width of 1000px, so I'm wondering if we should set this width for the Group block that is wrapping all the blocks, what do you think?
|
Could you let me know if you pulled the last changes on this repo? The things that you noticed should be already fixed 🤔 Screen.Capture.on.2023-03-23.at.09-43-02.mp4 |
7 tasks
thealexandrelara
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Thank you @gigitux, I think it might be related to a cache issue, now it is working perfectly. Approving this PR. Thank you all for working on this!
danielwrobert
added a commit
that referenced
this pull request
Mar 29, 2023
By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context.
3 tasks
danielwrobert
added a commit
that referenced
this pull request
Mar 30, 2023
* Remove isExperimentalBuild checks. By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context. * Revert isExperimentalBuild removal on registration The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset.
tarunvijwani
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Remove isExperimentalBuild checks. By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context. * Revert isExperimentalBuild removal on registration The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset.
opr
added a commit
that referenced
this pull request
Apr 3, 2023
* Empty commit for release pull request * Add WC Blocks 9.9.0 changelog * Update supported versions for WC Blocks 9.9.0 * Update versions for WC Blocks 9.9.0 * Add testing notes for 9.90 release * Update testing instructions Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Remove active the latest trunk part from the testing instructions Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Add instructions to activate WP release candidates - Add the editor type for each reference. - Add instructions to activate WP release candidate * Fix readme file reference * Fix unlinked border widths in WP 6.2 (#8893) * Check for address on shippingData (#8878) * Make a Single Product conversion enabled in Core, but keep the Product Archive behind experimental flag (#8907) * Remove `isExperimentalBuild` Checks in Classic Template Block (#8902) * Remove isExperimentalBuild checks. By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context. * Revert isExperimentalBuild removal on registration The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset. * Update changelog and testing instructions to include cherry-picked PRs * Update release zip * Update readme to be in correct order --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: kmanijak <karol.manijak@automattic.com> Co-authored-by: Daniel W. Robert <danielwrobert@users.noreply.github.com> Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8208
Screenshots
Screen.Capture.on.2023-03-23.at.09-43-02.mp4
Testing
Automated Tests
User-Facing Testing
Prerequisites:
WordPress: >=6.1
Make sure
Single Producttemplate is cleared out to the default state. To achieve that:/wp-admin/site-editor.php?postType=wp_template)Clear customizationsSteps
Single Producttemplate.Upgrade to Blockified Single Product Templatebutton.WooCommerce Visibility
Changelog
Description updated by @gigitux