This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Revert "Set inherit
setting to true when is inserted in the archive product template"
#8352
Merged
nielslange
merged 1 commit into
trunk
from
revert-8251-add/8216-enable-inherit-on-archive
Feb 1, 2023
Merged
Revert "Set inherit
setting to true when is inserted in the archive product template"
#8352
nielslange
merged 1 commit into
trunk
from
revert-8251-add/8216-enable-inherit-on-archive
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
February 1, 2023 11:27
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -387 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
nielslange
force-pushed
the
revert-8251-add/8216-enable-inherit-on-archive
branch
from
February 1, 2023 12:19
bacabd7
to
00746dc
Compare
nielslange
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll ⛴ it to proceed with release 9.5.0. Thanks for reverting this PR so quickly, @albarin! 🙌
github-actions
bot
added
status: ready to merge
and removed
status: ready to merge
labels
Feb 1, 2023
nielslange
added a commit
that referenced
this pull request
Feb 1, 2023
* Empty commit for release pull request * Update readme.txt * Bump “minimum_supported_wp_version” in phpcs.xml * Add testing notes * Update 950.md * Update 950.md * Update 950.md * Update 950.md * Update 950.md * Update 950.md * Update #8202 testing instructions. * Revert "Set inherit default to true only when is inserted in the archive product template (#8251)" (#8352) This reverts commit 39b0f91. * Update release ZIP file * Bumping version strings to new version. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Daniel Dudzic <daniel.dudzic@automattic.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com>
tarhi-saad
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8251