This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: color setting for Catalog Sorting #8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
dinhtungdu
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +795 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Approving because it fixes the color issue. However, it looks like WC core adds some styles to TT3 which override the font-size value:
| Editor | Frontend (TT3) |
|---|---|
 |
 |
We should either increase the specific of our CSS rules or investigate how to reduce the specificity in the selector from WC core. In any case, it can be done in a follow-up if you prefer.
|
@Aljullu Given that this PR is small, I update the selector to fix the font size overridden by theme issue, can you please take another look at this PR? |
Aljullu
reviewed
Feb 3, 2023
| @@ -3,8 +3,8 @@ | |||
| float: none; | |||
| } | |||
|
|
|||
| select { | |||
| select.orderby { | |||
There was a problem hiding this comment.
For some reason, the <select> in the editor doesn't have the orderby class for me. So the styles are not applied:
In the frontend, everything works well. Can you reproduce?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #8122
This PR fixes the issue that the color setting is applied in the editor and on the front end. This also remove the unused style for the Catalog Sorting
selectbox.Testing
Automated Tests
User Facing Testing
WooCommerce Visibility