This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix the related products block result when used along a grouped product #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +50 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
For some reason, in my case when I try accessing the Single Product page (on the frontend side) the page is broken with the following error:
It seems to be related to the $product->get_id() call on line 152 in the RelatedProducts.php file. Can you reproduce it?
…ocks into fix/8589-wrong-results-grouped-blocks
…b.com/woocommerce/woocommerce-blocks into fix/8589-wrong-results-grouped-blocks
Yes, I tested the block always below the Classic Single Grid Block. The issue is that the variable $product is set when the loop is started (source code). The filter This issue didn't happen when the block was below the Classic Single Grid Block because the block triggered the loop, and WC set the product in the global variable. I fixed it via ab0f601 |
7 tasks
| * @return string The block content. | ||
| */ | ||
| public function render_block( string $content, array $block ) { | ||
| if ( ! $this->is_related_products_block( $block ) ) { |
There was a problem hiding this comment.
I'm wondering if this conditional is really necessary, because by default on line 120, it will always return the $content, except if the count( $related_products_ids ) < 1 (on line 117)
There was a problem hiding this comment.
This function is hooked to the render_block filter. So this means that every function hooked to the render_block is executed for each block that will be rendered. For this reason, I do this check.
thealexandrelara
approved these changes
Mar 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the related products block result when used along a grouped product: following WC Core, the block should not show any product.
Furthermore, I put inside the Related Products block a heading block with the text:
Related Products. This is necessary because we only want to show theRelated Productstext when the related products block shows products. For this reason, it will be necessary to update #8515Fixes #8589
User Facing Testing
WooCommerce Single Product Block, add theRelated Products block.Related Products blockare equal to the row generated by theWooCommerce Single Product Block.Related Products blockare equal to the row generated by theWooCommerce Single Product Block. (no product should be displayed)WooCommerce Visibility