This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Change the property name of the attribute slug in Products By Attribute #8759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te after the refactor
kmanijak
added
type: bug
The issue/PR concerns a confirmed bug.
block: products by attribute
Issues related to the Products by Attribute block.
labels
Mar 15, 2023
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
March 15, 2023 11:17
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Aljullu
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for investigating and fixing it, @kmanijak!
Size Change: +4 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Aljullu
pushed a commit
that referenced
this pull request
Mar 15, 2023
…te after the refactor (#8759)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: products by attribute
Issues related to the Products by Attribute block.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As of 9.8.0 Products by Attribute block renders empty.
Cause
Due to refactoring done in #8583, the properties returned by SearchListItem changed and didn't match the Products by Attribute interface.
Due to that,
attr_slug
was not sent to the backend and there was an empty response, so the block was rendered empty.Fixes #8755
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog