This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Single Product Template: add the Store Notice block to the template #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Product Image Gallery
…ocks into add/8233-product-image-gallery-block
When used in a Row block in a blockified Archive Product template, Product Results Count had additional unnecessary margin which caused misalignment with the Catalog Sorting block
It was added couple of commits earlier, since the template was kept there, but it was decided to move it to assets directory, so entry is no longer necessary
…on the availability to convert to Products block
…in blockified Archive Product template
…ell as Single Product templates
…/woocommerce-blocks into add/convert-classic-template
…ex.tsx to the product-archive.ts
…ed template blocks aligned wide That is required, so the Classic Template layout is preserved
…://github.com/woocommerce/woocommerce-blocks into add/8208-convert-single-product
…://github.com/woocommerce/woocommerce-blocks into add/8208-convert-single-product
…://github.com/woocommerce/woocommerce-blocks into add/8208-convert-single-product
…ocks into add/8208-convert-single-product
gigitux
added
type: enhancement
The issue is a request for an enhancement.
skip-changelog
PRs that you don't want to appear in the changelog.
focus: template
Related to API powering block template functionality in the Site Editor
labels
Mar 23, 2023
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
March 23, 2023 10:36
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +3 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
…ocks into add/notice-block-single-product-template
@thealexandrelara the PR is ready to be reviewed! |
thealexandrelara
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and it is working as expected. Thank you! 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: template
Related to API powering block template functionality in the Site Editor
skip-changelog
PRs that you don't want to appear in the changelog.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Store Notice block to the Single Product Template.
Testing
Automated Tests
User Facing Testing
Prerequisites:
WordPress: >=6.1
Make sure
Single Product
template is cleared out to the default state. To achieve that:/wp-admin/site-editor.php?postType=wp_template
)Clear customizations
Steps
Single Product
template.Upgrade to Blockified Single Product Template
button.WooCommerce Visibility