This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Image Gallery: Prevent image placeholder from going outside its wrapper #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +2 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
nefeline
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
LGTM 🎉 !
Test Results
Click on the "Product Image Gallery" block, and add it to the editor;
Resize the window and make sure that the placeholder image adjusts itself to the block wrapping it
✅ Confirmed the product image gallery block is resizing as expected.
thealexandrelara
deleted the
fix/product-image-gallery-block-placeholder
branch
opr
added
type: bug
|
@thealexandrelara I added the correct labels for your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the users resize the window or access smaller screen sizes, the placeholder image is not resized to fit the wrapper component. This PR solves that by removing the fixed
widthof the placeholder and allowing it to adjust itself accordingly to its container.Fixes #8742
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog