This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove isExperimentalBuild Checks in Classic Template Block
#8902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context.
danielwrobert
added
focus: FSE
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -1 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Thank you @danielwrobert for addressing this so quickly. Just tested and it is working as expected, can't see any side-effects, great job! 🚀
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset.
|
@thealexandrelara I pushed an update in 3ee34d5, if you can have another look when you have a chance - thanks! I also updated the test plan to clarify that you need to run |
albarin
approved these changes
Mar 30, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tarunvijwani
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Remove isExperimentalBuild checks. By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context. * Revert isExperimentalBuild removal on registration The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset.
opr
added a commit
that referenced
this pull request
Apr 3, 2023
* Empty commit for release pull request * Add WC Blocks 9.9.0 changelog * Update supported versions for WC Blocks 9.9.0 * Update versions for WC Blocks 9.9.0 * Add testing notes for 9.90 release * Update testing instructions Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Remove active the latest trunk part from the testing instructions Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Add instructions to activate WP release candidates - Add the editor type for each reference. - Add instructions to activate WP release candidate * Fix readme file reference * Fix unlinked border widths in WP 6.2 (#8893) * Check for address on shippingData (#8878) * Make a Single Product conversion enabled in Core, but keep the Product Archive behind experimental flag (#8907) * Remove `isExperimentalBuild` Checks in Classic Template Block (#8902) * Remove isExperimentalBuild checks. By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context. * Revert isExperimentalBuild removal on registration The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset. * Update changelog and testing instructions to include cherry-picked PRs * Update release zip * Update readme to be in correct order --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: kmanijak <karol.manijak@automattic.com> Co-authored-by: Daniel W. Robert <danielwrobert@users.noreply.github.com> Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the
isExperimentalBuildconditional checks in the Classic Template block, we ensure that the capability of switching to the blockified Single Product Template will land in WooCommerce Core and not be limited to the feature plugin.This is an adjustment from #8324. The test plan is the mainly the same, with some minor adjustments.
See p1680000654295729-slack-C02UBB1EPEF for additional context.
Screenshots
Screen.Capture.on.2023-03-23.at.09-43-02.mp4
Testing
Prerequisites:
WordPress: >=6.1
Make sure
Single Producttemplate customizations are reset to the default state:/wp-admin/site-editor.php?postType=wp_template)Clear customizationsSteps
npm run build:deploy).Single Producttemplate.Upgrade to Blockified Single Product Templatebutton.WooCommerce Visibility
Changelog