This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Product Rating Block not showing when manually inserted to Single Product Block #9413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/atomic/blocks/product-elements/rating/edit.tsx
|
|
Size Change: +91 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
thealexandrelara
changed the title
…ally-added-to-single-product-block
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
nefeline
reviewed
May 11, 2023
| @@ -33,11 +34,25 @@ const Edit = ( { | |||
| ...context, | |||
| }; | |||
| const isDescendentOfQueryLoop = Number.isFinite( context.queryId ); | |||
| const { isDescendentOfSingleProductBlock } = useSelect( ( select ) => { | |||
There was a problem hiding this comment.
Would it be worth having this logic stored as a React hook for shared usage across all inner blocks for the Single Product? Could other blocks, such as price and add to cart, also benefit from this change?
There was a problem hiding this comment.
Yes! I agree with this, today I opened another PR to an issue that I was investigating and I found out that it was being caused by the same thing, so I created a hook in that PR that I'll be using to refactor this and other blocks that need it
There was a problem hiding this comment.
Cool! Looking forward to having #9446 merged so this PR can benefit from this update.
thealexandrelara
deleted the
fix/product-rating-not-displaying-when-manually-added-to-single-product-block
branch
Merged
14 tasks
thealexandrelara
added
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves an issue that was being caused when manually adding the Product Rating block to the Single Product block. The "isDescendentOfSingleProductBlock" attribute is what defines how the Product Rating block will behave depending on the context in which it is inserted. The issue is that when the Product Rating block was manually added, this attribute remained with a
falsevalue, so this way the block didn't know that it was inside the context of the Single Product block.Walkthrough
🤖 Generated by Copilot at 8b7b69e
useSelecthook from@wordpress/datapackage to select data from WordPress data store (link)Editcomponent to useuseSelecthook to check if block is a descendent ofwoocommerce/single-productblock and store result in new attributeisDescendentOfSingleProductBlock(link)isDescendentOfSingleProductBlockandisDescendentOfQueryLoopattributes (link)useEffecthook to set both attributes when component mounts or updates (link)BlockAttributesinterface to include new attribute (link)Fixes #9333
Accessibility
prefers-reduced-motionOther Checks
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility