This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix undo button #9478
Merged
Fix undo button #9478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +245 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
@gigitux the undo button now works as expected, thanks for the quick fix! 🎉
One minor thing I noticed while testing: the text for the description of the Classic Product Template reads:
Transform this template into multiple blocks so you can add, remove, reorder, and customize your single product.
That seems correct but I wanted to confirm because in your testing instructions you end that sentence with single product template, not just single product.
There was a problem hiding this comment.
@gigitux the undo button now works as expected, thanks for the quick fix! 🎉
One minor thing I noticed while testing: the text for the description of the Classic Product Template reads:
Transform this template into multiple blocks so you can add, remove, reorder, and customize your single product.
That seems correct but I wanted to confirm because in your testing instructions you end that sentence with single product template, not just single product.
|
^^ Strange that it posted my comment 2x. 🤔 🤷♂️ |
danielwrobert
approved these changes
May 16, 2023
Thanks for catching this! It was a bug. We are using
Fixed with 33fd3a0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the undo button introduced with #9386.
Testing
User Facing Testing
WooCommerce Visibility