This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Product Rating block: Hide rating when the product has no reviews #9556
Merged
thealexandrelara
merged 2 commits into
trunk
from
feat/9270-hide-add-review-link-from-product-rating-block
May 25, 2023
Merged
Product Rating block: Hide rating when the product has no reviews #9556
thealexandrelara
merged 2 commits into
trunk
from
feat/9270-hide-add-review-link-from-product-rating-block
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealexandrelara
changed the title
Remove Add Review link and hide rating when the Product has no rating
Product Rating block: Hide rating when the product has no reviews
May 19, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
π π This PR does not introduce new TS errors. |
Size Change: -97 B (0%) Total Size: 1.09 MB
βΉοΈ View Unchanged
|
thealexandrelara
added
type: enhancement
The issue is a request for an enhancement.
block: product rating
Issues related to the Product Rating block
labels
May 22, 2023
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
May 22, 2023 18:04
gigitux
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this PR, but let me tag @shaunandrews that could have some feedback that we could take care of in a follow-up PR if necessary.
thealexandrelara
deleted the
feat/9270-hide-add-review-link-from-product-rating-block
branch
May 25, 2023 14:49
Thanks for the feedback, @shaunandrews! Should we show the label only on the site editor or on the front end as well? |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: product rating
Issues related to the Product Rating block
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
π€ Generated by Copilot at e4efbf4
π¨βπ» Enhanced by @thealexandrelara
Removed the
AddReview
component from the rating block and replaced it with a mocked rating component for products with no reviews.Walkthrough
π€ Generated by Copilot at e4efbf4
π¨βπ» Enhanced by @thealexandrelara
AddReview
component and related logic from rating block (link, link, link, link, link)shouldDisplayMockedReviewsWhenProductHasNoReviews
prop to rating block to toggle mocked rating component when on the Editor (link, link)shouldDisplayMockedReviewsWhenProductHasNoReviews
prop is true (link, link)Fixes #9270
Accessibility
prefers-reduced-motion
Other Checks
User Facing Testing
Product Rating block inside Single Product Block with a selected product that contains reviews
On Editor:
On Frontend:
Product Rating block inside Single Product Block with a selected product that has NO reviews
On Editor:
On Frontend:
Product Rating block inside Related Products Block
On Editor:
On Frontend:
WooCommerce Visibility
Performance Impact
Changelog