Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Use asym key to sign webhooks #1

Closed
6543 opened this issue May 19, 2022 · 8 comments
Closed

Use asym key to sign webhooks #1

6543 opened this issue May 19, 2022 · 8 comments

Comments

@6543
Copy link
Member

6543 commented May 19, 2022

If woodpecker-ci/woodpecker#916 lands, this repo need some adjustments ...

@s00500 your feedback would be welcome there too ;)

@s00500
Copy link
Collaborator

s00500 commented May 19, 2022

This looks like a great change, I can update the repo on the weekend if I find a bit of time

@anbraten
Copy link
Member

No hurry, I could do that as well.

@s00500
Copy link
Collaborator

s00500 commented May 19, 2022

Ok if you are on it already :-)

@6543
Copy link
Member Author

6543 commented Jun 1, 2022

ok it got merged :)

@6543 6543 changed the title Use async key to sign webhooks Use asym key to sign webhooks Jun 1, 2022
@anbraten
Copy link
Member

anbraten commented Jun 1, 2022

I have adjusted the code and docs to use an asym key.

@6543 6543 closed this as completed Jun 1, 2022
@s00500
Copy link
Collaborator

s00500 commented Jun 2, 2022

Nice work!

@anbraten
Copy link
Member

anbraten commented Jun 2, 2022

Thanks, also for your initial work 😉. I am so excited for woodpecker-ci/woodpecker#915 which will allow us to configure extensions (like config, secrets & registry service) on a per repo base.

@s00500
Copy link
Collaborator

s00500 commented Jun 2, 2022

Taking it to the big stage! great work, I am currently working woodpecker into our new production deployment so maybe I will have some more time contributing some stuff... lets see

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants