Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Drone CI #3

Closed
Adito5393 opened this issue Jul 10, 2022 · 4 comments · Fixed by #6
Closed

Add compatibility with Drone CI #3

Adito5393 opened this issue Jul 10, 2022 · 4 comments · Fixed by #6

Comments

@Adito5393
Copy link
Contributor

Would you accept a PR that would add compatibility with Drone CI via their env vars?

Following env vars will be added:

  • DRONE_REPO_OWNER -> CI_REPO_OWNER
  • DRONE_REPO_NAME -> CI_REPO_NAME (in Drone CI_REPO_NAME is set as DRONE_REPO_OWNER/DRONE_REPO_NAME )
  • DRONE_PULL_REQUEST -> CI_COMMIT_PULL_REQUEST
@anbraten
Copy link
Member

I think it wouldn't hurt to much to add them. I would just not "document" them officially, so we can adjust / remove them later without a warning if needed.

PS: Is there anything blocking you from migrating to woodpecker or why do you want to use drone in general 😅

@Adito5393
Copy link
Contributor Author

That sounds like a fair deal. I will implement the vars & test what happens when both CI_REPO_NAME & DRONE_REPO_NAME are set.

As I mentioned in #1, I'm waiting for cron jobs PR woodpecker-ci/woodpecker#934 to be merged. I will keep an eye on Woodpecker and try to contribute whenever possible 😃

PS: good job on sumarizing the ROADMAP issue woodpecker-ci/woodpecker#869

@ivictbor
Copy link

ivictbor commented Sep 1, 2022

I think deprecation warnings for such wariables would be awesome, otherwise users risk to get a chaose in their config (will check some example with old vars, blog posts etc)

Though pretty hard to implement, one thing that comes to mind - simply do full-text search in pipeline files for deprecated vars. Not covers cases when they are used in nested processes but at least something

@anbraten
Copy link
Member

anbraten commented Sep 1, 2022

I thought about adding two types of pipeline "linter" feedbacks. One for error and one for warnings. Warnings could be used for deprecations as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants