Global when does not work together with global branches filter [solved]

[lonix1]

Component

server

Describe the bug

The docs show an example of a global when with branch condition:

when:
  branch: master

When I tried that, I get an error:

Execution error
failed to parse pipeline: could not apply deprecated branches filter into global when filter

System Info

version "next-b616a822a0-alpine"

Additional context

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[6543]

witch forge do you use?

[lonix1]

gitea

[lonix1]

I just tried the latest version next-45319b24cd-alpine but same result.

[6543]

this is strange I tested this config and it does exactly what I expect:

when:
    branch: main

steps:
    echo:
        image: bash
        commands: echo ja

I get a pipeline on main but no other branch

[6543]

what event did you use as trigger?

(mine was a push)

[lonix1]

Sorry I just test it 10 different ways until I found the problem, and it's me.

when:
  event: push
  branch: master          # <--- I thought the error referred to this
  path: "src/*"

steps:
  build:
    image: alpine
    commands:
      - echo 'hello world'

branches: master          # <--- but it actually referred to this!!!

I think I was looking at the stable and next versions of the docs at the same time! The one is from the old stable and the other is from the next.

Again apologies! 🙏

The "next" version becoming stable is really needed. I'm wathicng that milestone daily! :-)

[lonix1]

I think the problem is somestimes when clicking links in the docs, if I'm not careful it redirects to the wrong version. Easy to get confused. I will keep an eye on that and report anything weird.

[lonix1]

Interesting point though, that is was deprecated. I assume there is no replacement for "global when with branch".

[6543]

tldr: global when was introduced in next (upcomming v1.0.0) and do deprecate the old global branches filter ...

there is a "migration" running to make transition smoth:

woodpecker/pipeline/frontend/yaml/parse.go

Lines 20 to 30 in 45319b2

	// support deprecated branch filter
	if out.BranchesDontUseIt != nil {
	if out.When.Constraints == nil {
	out.When.Constraints = []constraint.Constraint{{Branch: *out.BranchesDontUseIt}}
	} else if len(out.When.Constraints) == 1 && out.When.Constraints[0].Branch.IsEmpty() {
	out.When.Constraints[0].Branch = *out.BranchesDontUseIt
	} else {
	return nil, fmt.Errorf("could not apply deprecated branches filter into global when filter")
	}
	out.BranchesDontUseIt = nil
	}

but you should not use the old and the new ways at the same time ... dont expect magic :D

[lonix1]

No of course not, it wasn't an expectation of magic... it was stupidity on my part! ☺️

I discovered the issue BTW, when you go to the docs it always opens the stable version by default. So I have some browser tabs showing stable and some showing next. It's easy to get mixed up, BUT, I should have known better!

[6543]

#1855 will fix that