Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema out of date #2020

Closed
5 tasks done
lonix1 opened this issue Jul 20, 2023 · 4 comments
Closed
5 tasks done

JSON schema out of date #2020

lonix1 opened this issue Jul 20, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@lonix1
Copy link
Contributor

lonix1 commented Jul 20, 2023

Component

other

Describe the bug

Since #1948 was fixed (yesterday), the json schema for .woodpecker.yml is out of date, but that issue was locked so I can't comment there.

This is possible so that the logs show "clone" (as it was before the fix) instead of "git":

clone:
  clone:           # can be any word: "clone", "git" or whatever
    image: woodpeckerci/plugin-git:2.0.3
steps:
  build:
    # ...

But the schema only allows "git". If I use "clone" then I get an error in vscode: Property clone is not allowed..

I couldn't submit a PR because I'm unsure how to fix it - I can't just change "git" to "clone" as both are valid, as well as any other word.

(I'm willing to try fixing it if someone has an idea how to specify "any word"?)

System Info

version next
vscode

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@lonix1 lonix1 added the bug Something isn't working label Jul 20, 2023
@6543
Copy link
Member

6543 commented Aug 3, 2023

#2063

@6543 6543 closed this as completed Aug 3, 2023
@lonix1
Copy link
Contributor Author

lonix1 commented Aug 3, 2023

If I understand correctly, that one seems to be about links which are out of date.

This one is about a schema change due to a code change.

Is it really a dupe?

@6543
Copy link
Member

6543 commented Aug 3, 2023

Well I'm not aware of how we should version tje schemastore ... so it can only bee about making sure it's about latest stable ...

@lonix1
Copy link
Contributor Author

lonix1 commented Aug 3, 2023

Ok thanks. I will add the above use case to the other issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants