Woodpecker UI isn't showing secrets's names with uppercase.

[GamePlayer-8]

Component

web-ui

Describe the bug

Writing secrets with uppercase i.e. OCI_TOKEN is being interpreted as oci_token for the web UI although it stays as OCI_TOKEN in the workflow.

System Info

`{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-5bd12aa646"}`

Additional context

Might be related to #2084

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[anbraten]

Woodpecker internally converts all secrets to lower case: https://github.com/search?q=repo%3Awoodpecker-ci%2Fwoodpecker%20.ToLower&type=code

I think the corresponding env var if secrets: is supplied is uppercase

[GamePlayer-8]

the problem is that it's not converting uppercase env variable into lowercase for the workflow then.

[qwerty287]

@GamePlayer-8 I don't really understand what you mean. Secret env vars are and should be uppercase, no matter the secret name.

[GamePlayer-8]

Secret isn't displayed as uppercase in the UI of woodpecker after adding it, even if I type it all with uppercase.

[qwerty287]

That's also intentional because all secret names are converted to lowercase. However, in workflow yamls you should be able to use them case-insensitive.

[GamePlayer-8]

I've tried to call the lowercase & I got no data while with uppercase I've got the secret. Shouldn't the environment variable inside the workflow be converted to lowercase to avoid confusion?

[qwerty287]

No, env vars should always be uppercase.
I mean that you can inject secrets in yaml case-insensitively, so you can use from_secret: xyz or from_secret: XYZ

[GamePlayer-8]

I'm using:

secrets:
 - xyz
 - XYZ

And only with the uppercase contains the actual secret.

[qwerty287]

Hmm then this should be updated.

[anbraten]

secrets are always converted to lowercase. Env vars which the secret is exposed as if using - secrets: [secret_name] are currently uppercase. I see the confusion. Actually full uppercase could be better.