Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if branch has no pipeline definition #2579

Closed
5 tasks done
pat-s opened this issue Oct 14, 2023 · 2 comments
Closed
5 tasks done

Don't fail if branch has no pipeline definition #2579

pat-s opened this issue Oct 14, 2023 · 2 comments

Comments

@pat-s
Copy link
Contributor

pat-s commented Oct 14, 2023

Component

server, web-ui

Describe the bug

In a repo where builds are only desired for a specific branch (excluding the default branch), the following happens:

  • On a push to a custom branch which has a valid pipeline definition, everything works
  • On a push to any other of the repo the webhook is also triggered but the build will immediately fail due to a missing pipeline config

image

The use case I have here is that I maintain a fork. I build some stuff in a custom branch but always keep main/master in sync with upstream.
Hence, only the custom branch has a pipeline definition and whenever the main branch is synced with upstream, the above error occurs.

I think it would be good if WP first checks for any existence of a valid WP YAML file and if none is found, just does nothing - instead of throwing an error?

System Info

next-8629a418f8

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@pat-s pat-s added the bug Something isn't working label Oct 14, 2023
@anbraten
Copy link
Member

linking #2313

@qwerty287
Copy link
Contributor

Duplicate #2312

@qwerty287 qwerty287 added duplicate and removed bug Something isn't working labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants