-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go module path for major version 2 #2913
Comments
That's pretty annoying that we have to update the import paths of the whole codebase each time we release a major version 🙈 However I guess we need to change it then and release 2.1.0 to fix it. |
I guess the versioning of the go library and other go code can be separated somehow. |
Maybe we should move the woodpecker-go SDK to its own repo? But for now, I'd merge the PR and do this afterwards. |
https://go.dev/doc/modules/release-workflow#breaking Fixes #2913 fixes #2654 ``` runephilosof@fedora:~/code/platform-woodpecker/woodpecker-repo-configurator (master)$ go get go.woodpecker-ci.org/woodpecker@v2.0.0 go: go.woodpecker-ci.org/woodpecker@v2.0.0: invalid version: module contains a go.mod file, so module path must match major version ("go.woodpecker-ci.org/woodpecker/v2") ``` --------- Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Component
other
Describe the bug
Getting versiogo.woodpecker-ci.org/woodpecker/v2n 2.0.0 of the go library results in an error
System Info
Additional context
No response
Validations
next
version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]The text was updated successfully, but these errors were encountered: