Release event not working as expected

[xoxys]

Component

server

Describe the bug

release events result in an empty pipeline even if no event filter is set in the workflow:

woodpecker-server-forgejo   | {"level":"debug","pipeline":"demo","time":"2024-04-30T07:39:38Z","caller":"/build/server/pipeline/stepbuilder/stepBuilder.go:156","message":"marked as skipped, does not match metadata"}
woodpecker-server-forgejo   | {"level":"debug","pipeline":"test","time":"2024-04-30T07:39:38Z","caller":"/build/server/pipeline/stepbuilder/stepBuilder.go:156","message":"marked as skipped, does not match metadata"}
woodpecker-server-forgejo   | {"level":"debug","repo":"testorg/woodpecker-test","time":"2024-04-30T07:39:38Z","caller":"/build/server/pipeline/create.go:103","message":"ignoring hook: 'when' filters filtered out all steps"}

I've only tested it with gitea/forgejo this might affect other forges as well.

System Info

next-00ccec078c

Additional context

No response

Validations

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[qwerty287]

Which filters (except event) do you have set?

[everflux]

The webhook that is created by Woodpecker 2.5 does not include the "release" type in gitea. When manually adding this type to the webhook, woodpecker is triggered as expected.
BUT two builds are triggered: one for the tag creation and one for the release creation. This can be handled using appropriate filters, of course.

[anbraten]

The webhook that is created by Woodpecker 2.5 does not include the "release" type in gitea. When manually adding this type to the webhook, woodpecker is triggered as expected.

Seems to be actually missing: https://github.com/anbraten/woodpecker/blob/62ae7b2e213d861bbc6c61154b266066f1e92f9c/server/forge/gitea/gitea.go#L386

BUT two builds are triggered: one for the tag creation and one for the release creation. This can be handled using appropriate filters, of course.

That's expected as both a different events.

[qwerty287]

Even though this event is missing this seems to be not the problem of the issue. Take a look at the screenshot - the hook is sent from a release event

[everflux]

I tested the release, worked for me in a pipeline with 2.4.1 and 2.5
From the log output it seems the event was emitted but ignored, hard to diagnose without the actual workflow.

ignoring hook: 'when' filters filtered out all steps

[everflux]

Tested with gitea 1.21.7 and WP 2.6.0, both freshly installed. Works like a charm.

The latest gitea 1.22 (about two weeks young) mentions as enhancement in the changelog:

Make gitea webhooks openproject compatible (go-gitea/gitea#28435) (go-gitea/gitea#31081)

Maybe this leads to problems. I will try to test it with a fresh setup with gitea 1.22

[qwerty287]

@xoxys Do you still have issues with the release event?

[xoxys]

I can try to reproduce it on the weekend. Im also fine to close this issue for now and only re-open it if Im able to.

[qwerty287]

closing for now

[xoxys]

Thanks, sorry for not providing feedback till now. Ill reopen it of I find some time to test it.