Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rsa for http signing #865

Closed
anbraten opened this issue Apr 3, 2022 · 1 comment · Fixed by #916
Closed

Use rsa for http signing #865

anbraten opened this issue Apr 3, 2022 · 1 comment · Fixed by #916

Comments

@anbraten
Copy link
Member

anbraten commented Apr 3, 2022

Using rsa for http would allow us to keep the secret secret 😉
This will be especially helpful when allowing more extensions in addition to the current configuration service to be settable per repo.
The current lib used for signing doesn't support that but we could try https://github.com/go-fed/httpsig

@mscherer
Copy link
Contributor

The current lib seems not maintained (last commit in 2017), but the new one seems also not moving a lot (last commit 1 year ago). But that's indeed better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants