-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changed files for Gitea PRs #1342
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1342.surge.sh |
Co-authored-by: 6543 <6543@obermui.de>
thanks ❤️ now only tests are missing I think you can just look into github remote as there already should be some in that you can copy/use as template |
Co-authored-by: Lauris BH <lauris@nix.lv>
@6543 GitHub doesn't contain any tests for this, I'll add some new (for Gitea) though. |
I tried to add some tests now, but without real success. The issue is that this new method needs to access the user token and I don't really know how I can inject a user into it without having to inject a store in the context. I can add a new key |
This comment was marked as off-topic.
This comment was marked as off-topic.
For a failing example of a test and the user-debug key look at cb5e784 |
added tests by using the mock_store |
@6543 There's this lint
|
How can I fix this? |
We cant as we use gin framework We would have to patch that upstream |
This comment was marked as outdated.
This comment was marked as outdated.
- add tests to fetch changed files - ignore error if gitea version is to low - adjust docs accordingly Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv>
#1138
TODOs: