Enable golangci linter goconst #3169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Jan 11, 2024
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3169.surge.sh |
|
Not sure I like this linter 🤣 |
|
No strong opinion, feel free to close unmerged. |
|
It's too strict on values as can be seen already in a lot of places need to add nolint comment, personally I don't like it because of it |
|
Well... There are only a few places where excludes were added... However. |
|
I agree to @lafriks. we don't need separate variables for value like If we do this, please move the consts out of the migrations to |
|
Please make a decision first if the linter should be activated or not before I spend more time on it. |
|
I think we shouldn't enable it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #2960