Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final release produces a Prerelease on when publish Github Release #74

Open
Larusso opened this issue Sep 2, 2021 · 1 comment
Open
Assignees

Comments

@Larusso
Copy link
Member

Larusso commented Sep 2, 2021

Description

When executing a final release for a WDK project the actual github release is marked as prerelease.
I checked the code and it looks like we changed the check values during the gradle upgrade process.
Currently we check for project.status != 'final'.
as seen here:

githubPublishTask.prerelease.set(project.provider { project.status != 'final' })

The old code did check
githubPublishTask.setPrerelease({ project.status != 'release' })

We need to fix this and maybe provide a test case to verify this.

@Azurelol
Copy link
Contributor

Azurelol commented Sep 2, 2021

Should it then check for (not final OR not release)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants