Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static API #28

Open
zonuexe opened this issue Nov 15, 2015 · 1 comment
Open

Static API #28

zonuexe opened this issue Nov 15, 2015 · 1 comment

Comments

@zonuexe
Copy link
Contributor

zonuexe commented Nov 15, 2015

refs #25

I understand that instance is useful for SoC.
But other implements (including Java) do not provided API for classifier instance.
I think it is not to bring confusion to the user be provide static and dynamic API.
What do you think? @tagomoris

@yuya-takeyama written #25 (comment):

Doesn't it cause any issue to call static methods in object context?

No problem. fb5b2e6 can revert.

@yuya-takeyama
Copy link
Member

I can understand your point (consistency between languages).
But IMO, it's not a matter.
Implementations should follow its languages's manner.

However, I can also understand the benefit of static method for its handiness to call.

My concerns are below.

  • Doesn't it cause any issue to call static methods in object context?
    • As @zonuexe says, it seems to have no problem for now.
  • It won't be changed in the future?
    • Calling a method in both way (statically and dynamically) seems bad manners to me.
    • In PHP, this kind of things are sometimes changed. (For example, calling non-static methods statically)
    • It leads me to unnecessary worry.

@woothee/woothee-php-team Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants