Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

[BE] refactor: 파서 및 렌더러 빈 등록, Writing과 Block 일대다 단방향 적용 #368

Merged
merged 5 commits into from
Sep 12, 2023
Merged

[BE] refactor: 파서 및 렌더러 빈 등록, Writing과 Block 일대다 단방향 적용 #368

merged 5 commits into from
Sep 12, 2023

Conversation

HubCreator
Copy link
Member

🛠️ Issue

✅ Tasks

  • 파서 빈 등록
  • 렌더러 빈 등록
  • Writing과 Block 일대다 단방향 적용

⏰ Time Difference

  • 3 -> 2

📝 Note

  • task들을 구분하여 커밋을 진행하려고 했는데, 빈에서 Writing을 참조하고 있는 부분이 있어서 일대다 단방향 적용과 빈 등록을 동시에 진행하였습니다. 한 번에 file changed가 많아져서 보기 힘드실 것 같아요. 빈을 등록하여 사용하는 부분과 참조관계가 바뀐 부분을 중점적으로 봐주시면 될 것 같습니다!

@HubCreator HubCreator self-assigned this Sep 5, 2023
echo724
echo724 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@echo724 echo724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꽤나 여러군데에 수정사항이 생겼을텐데 수정하느라 고생했어요!~ 깔끔하네요!

backend/src/main/java/org/donggle/backend/application/repository/WritingRepository.java Outdated
@@ -24,6 +25,7 @@ public interface WritingRepository extends JpaRepository<Writing, Long> {
"where w.nextWriting.id = :writingId")
Optional<Writing> findPreWritingByWritingId(@Param("writingId") final Long writingId);

@EntityGraph(attributePaths = "blocks")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 메서드를 사용하는데 blocks를 가져올 필요 없는 부분들에서도 사용되는 것 같아요! (글 제목 변경, 글 순서 변경 등). 메서드를 분리해서 가져오는게 좋을 것 같습니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요! ㅎㅎㅎ findByIdWithBlocks로 메서드 명을 변경하였고, Writing을 가져올 때에 Blocks 정보가 필요 없는 것들은 기본 메서드인 findById를 호출하도록 수정하였습니다!

backend/src/main/java/org/donggle/backend/application/service/WritingService.java

public Long uploadMarkDownFile(final Long memberId, final MarkdownUploadRequest request) throws IOException {
final String originalFilename = request.file().getOriginalFilename();
if (!Objects.requireNonNull(originalFilename).endsWith(MD_FORMAT)) {
throw new InvalidFileFormatException(originalFilename);
}
final String originalFileText = new String(request.file().getBytes(), StandardCharsets.UTF_8);
final List<Block> blocks = markDownParser.parse(originalFileText);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캬 깔끔하네요. 이제야 파서다워진 느낌입니다.

backend/src/main/java/org/donggle/backend/domain/parser/markdown/MarkDownParser.java
@@ -32,7 +33,6 @@ public class MarkDownParser {
private static final int SPACE_GROUP_INDEX = 2;

private final MarkDownStyleParser markDownStyleParser;
private final Writing writing;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋지네요 ㅜㅜ

backend/src/main/java/org/donggle/backend/domain/writing/block/Block.java
public Block(final Long id, final Writing writing, final Depth depth, final BlockType blockType) {
this.id = id;
this.writing = writing;
public Block(final Depth depth, final BlockType blockType) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요!

backend/src/main/java/org/donggle/backend/domain/writing/Writing.java
@@ -41,26 +47,34 @@ public class Writing extends BaseEntity {
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "category_id")
private Category category;
@OneToMany(cascade = CascadeType.PERSIST)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔합니다.. ㅜㅜ

ezzanzzan
ezzanzzan approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@ezzanzzan ezzanzzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져요 👍

@echo724 echo724 merged commit 0806b50 into develop Sep 12, 2023
@echo724 echo724 deleted the feature/register-bean-and-change-reference-365 branch September 12, 2023 05:18
echo724 pushed a commit that referenced this pull request Sep 22, 2023
@HubCreator @echo724
[BE] refactor: 파서 및 렌더러 빈 등록, Writing과 Block 일대다 단방향 적용 (#368)
a2f4fad 
* refactor: Writing에서 Block에 대한 일대다 단방향에 대한 수정과, 각 파서들을 빈으로 등록

* refactor: 렌더러 빈 등록

* refactor: 스프링 부트 테스트를 단위테스트로 수정 및 코드 스타일 수정

* refactor: 주석 제거

* feat: Writing 페치 조인 쿼리 분리 및 WritingNotFoundException 서비스에서 관리
echo724 pushed a commit that referenced this pull request Oct 6, 2023
@HubCreator @echo724
[BE] refactor: 파서 및 렌더러 빈 등록, Writing과 Block 일대다 단방향 적용 (#368)
a29214b 
* refactor: Writing에서 Block에 대한 일대다 단방향에 대한 수정과, 각 파서들을 빈으로 등록

* refactor: 렌더러 빈 등록

* refactor: 스프링 부트 테스트를 단위테스트로 수정 및 코드 스타일 수정

* refactor: 주석 제거

* feat: Writing 페치 조인 쿼리 분리 및 WritingNotFoundException 서비스에서 관리
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ingpyo ingpyo ingpyo approved these changes

@ezzanzzan ezzanzzan ezzanzzan approved these changes

@echo724 echo724 echo724 approved these changes

Assignees

@HubCreator HubCreator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

파서 및 렌더러 빈 등록, Writing과 Block 일대다 단방향 적용
4 participants
@HubCreator @echo724 @ezzanzzan @ingpyo