Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[장바구니 협업 Step 2] 윤생(이윤성) 미션 제출합니다. #151
[장바구니 협업 Step 2] 윤생(이윤성) 미션 제출합니다. #151
Changes from all commits
31a3818
61da3d3
5db4e31
62a32a8
e1365ad
569c91b
8a45a7a
f6a524b
a40342c
edecc95
4bf8f3e
5ca6f99
74b3d20
6d7ade0
97781dd
047a533
57c07c6
0f82763
68ef52c
88fa9a9
fb93d6b
f0ddd9b
998521b
10f7196
72c7e66
4672ed3
ced9246
cdec66e
fd25c85
d93dc9c
9529090
87aca32
44194f5
088bafb
e1c152a
1988141
22b617d
182d262
df0ac76
5c77373
9edc50c
49a714d
0085a23
4b0622d
8cdc625
b2f3fc2
dec5f69
b7a2439
6a11018
2758e1d
fe2fec5
84b0bde
ceb3db1
87f24c8
8b2999c
b4080c9
c8fd4ef
afdd6d0
c27542d
3d70bef
bd211d5
9327fc2
5202f4c
9c4a7bf
6a06eef
1591796
1bc151c
78a3ae5
767fae3
a13de27
650dc99
20642d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectedCoupons의 첫번째 요소만 확인해도 충분한가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allCoupon임을 처음에 if문(85번째줄)에서 보장한다고 생각해
도메인 상 선택 로직에서 하나만 선택할 수 있도록 보장하므로 충분하다고 생각합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allCoupon이 항상 요소 하나만 있는 배열임을 이 모듈 입장에서 항상 보장할 수 있는지에 대한 질문이었습니다. allCoupon의 스펙이 바뀌면 여기는 문제가 될 것 같군요