Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/implement mentions in gutenberg #13942

Merged
merged 44 commits into from
May 20, 2020
Merged

Issue/implement mentions in gutenberg #13942

merged 44 commits into from
May 20, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Apr 18, 2020 •
edited
Loading

This PR adds support for adding user mentions in the Block Editor (Gutenberg)

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2163

To test:

  • Start the app
  • Create a new post using GB (preferably on a site with multiple users)
  • Add a text block (paragraph, list, heading)
  • Tap on the @ icon on the toolbar
  • Check that the mention interface shows up
  • Tap characters and see if the list is filtered according
  • Select an option
  • Check if mention is added to the content
  • Repeat but this time, clean the suggestion completely or press the X button on the text field
  • Check if no mention is inserted.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Apr 18, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 18, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@SergioEstevao SergioEstevao added this to the 14.8 milestone Apr 18, 2020
@mchowning
Copy link
Contributor

Such a good gif! 😄

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 18, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@atwdeali
Copy link

org:35177729-Abosnd02-users-nore

@mchowning mchowning mentioned this pull request Apr 20, 2020
Merged
2 tasks
ceyhun
ceyhun suggested changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work overall! Thanks! I just encountered this issue:

I updated the Podfile commit hash to latest one here wordpress-mobile/gutenberg-mobile@8446c5b and installed pods again to test the latest changes. I got a crash doing the following:

  1. Open mentions
  2. Cancel
  3. Open again
  4. Select suggestion
  5. Crashes with a red screen

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift Show resolved Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMentionsViewController.swift Outdated Show resolved Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMentionsViewController.swift Show resolved Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMentionsViewController.swift Outdated Show resolved Hide resolved
@ceyhun
Copy link
Contributor

ceyhun commented Apr 21, 2020

I also realised an issue with the SuggestionsTableView not updating thumbnails in cells correctly. If you scroll very quickly and stop, the thumbnails still keep updating. But that's probably not related to the changes here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

ceyhun
ceyhun approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! Looks and works great 👍

@loremattei loremattei modified the milestones: 14.8 ❄️, 14.9 May 4, 2020
@loremattei
Copy link
Contributor

Hey! I'm moving this to 14.9 since 14.8 has been cut. Please, feel free to ping me if you want this to make it to 14.8.

@loremattei loremattei modified the milestones: 14.9 ❄️, 15.0 May 18, 2020
@loremattei
Copy link
Contributor

Hey! I'm moving this to 15.0 because 14.9 has been cut. If you want this to make it to 14.9, please feel free to ping me.

@SergioEstevao
Fix separator view color between the header and the tableview.
5beafbd 
When the header is clear use a color for separator, when the header
is translucent make it clear to avoid a blurry edge.
@SergioEstevao
Merge branch 'develop' into issue/implement_mentions_in_gutenberg
022bdab 
# Conflicts:
#	Podfile
#	Podfile.lock
@SergioEstevao SergioEstevao merged commit ea0717d into develop May 20, 2020
@SergioEstevao SergioEstevao deleted the issue/implement_mentions_in_gutenberg branch May 20, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@iamthomasbishop iamthomasbishop iamthomasbishop left review comments

@ceyhun ceyhun ceyhun approved these changes

@mchowning mchowning Awaiting requested review from mchowning

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@SergioEstevao @mchowning @atwdeali @ceyhun @loremattei @iamthomasbishop @houndci-bot