Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider move scrollEnabled prop to BlockList #2130

Closed
jbinda opened this issue Apr 8, 2020 · 0 comments · Fixed by #2145
Closed

Consider move scrollEnabled prop to BlockList #2130

jbinda opened this issue Apr 8, 2020 · 0 comments · Fixed by #2145
Assignees
@jbinda
Labels
InnerBlocks [Type] Technical Debt

Comments

@jbinda
Copy link
Contributor

jbinda commented Apr 8, 2020

Is your feature request related to a problem? Please describe.
During Column block PR I need to pass scrollEnable={false} to InnerBlock and FLatList to prevent inner blocks component to be scrollable. Only the RootList should be scrollable. According to
this comment we can consider moving mentioned prop directly to BlockList component to avoid passing it through InnerBlock API

It is small change however we decide to cover it separately and check if it do not break anything in other blocks.

I will prepare PR as soon as Column block PR gets merged.
@jbinda jbinda self-assigned this Apr 8, 2020
@jbinda jbinda changed the title Consider move scrollEnable={false} to RootList Consider move scrollEnable={false} to BlockList Apr 8, 2020
@jbinda jbinda changed the title Consider move scrollEnable={false} to BlockList Consider move scrollEnable prop to BlockList Apr 8, 2020
@jbinda jbinda changed the title Consider move scrollEnable prop to BlockList Consider move scrollEnabled prop to BlockList Apr 8, 2020
@jbinda jbinda mentioned this issue Apr 8, 2020
Merged
6 tasks
This was referenced Apr 9, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbinda jbinda

Labels
InnerBlocks [Type] Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: move scrollEnabled to BlockList wordpress-mobile/gutenberg-mobile
1 participant
@jbinda