Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration test] Buttons block - Breakage case - Border radius changes are not being stored #3667

Closed
fluiddot opened this issue Jun 25, 2021 · 0 comments · Fixed by WordPress/gutenberg#33211
Closed

[Integration test] Buttons block - Breakage case - Border radius changes are not being stored #3667

fluiddot opened this issue Jun 25, 2021 · 0 comments · Fixed by WordPress/gutenberg#33211
Assignees
@guarani
Labels
Integration test [Type] Task

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Jun 25, 2021 •
edited
Loading

PR where the breakage was fixed: WordPress/gutenberg#32717

Tasks

  1. Identify the block/component that is affected.
  2. Add a test file for covering the breakage in the block/component folder.
  3. Run the test and verify that it passes.
  4. Revert the changes made for the fix.
  5. Run the test again and verify that it fails.
  6. (Bonus) Add more test cases to the block/component.
  7. Celebrate 🥳 !

Notes

  • If a test already exists in the block/component folder, review if the test cases can be migrated to the integration test.
  • Some functionality might be not possible to replicate in the integration tests. In that case, indicate the blockers in the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guarani guarani

Labels
Integration test [Type] Task
Projects
None yet
Milestone
No milestone
2 participants
@guarani @fluiddot