Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More block #859

Closed
koke opened this issue Apr 12, 2019 · 5 comments · Fixed by #1079
Closed

More block #859

koke opened this issue Apr 12, 2019 · 5 comments · Fixed by #1079
Assignees
Labels

Comments

@koke
Copy link
Member

koke commented Apr 12, 2019

We have a working implementation, but split/merge doesn't work.

We need to decide if we use RichText, or fix #324 to add split/merge support to PlainText

@koke koke added the Blocks label Apr 12, 2019
@thehenrybyrd
Copy link

Had a request for the more block today in #2057785-zen
Looking forward to it! :)

@hypest
Copy link
Contributor

hypest commented Jun 3, 2019

Following up on a conversation over Slack, @iamthomasbishop has suggested that a shippable "v1" of the more block could be one that its "Read More" text is readonly. That is, we don't offer the ability to edit the message the block will display.

We could then iterate on that block to offer the full editable writing experience.

@rachelmcr
Copy link
Member

We could then iterate on that block to offer the full editable writing experience.

Are we tracking this as a planned second iteration somewhere? This came up while I was beta testing the more block today and I expect it will come up as a request from users once the block becomes available.

@iamthomasbishop
Copy link
Contributor

I’m not 100% sure on the status of this, but another option – if we’re experiencing difficulties with the dynamic on-canvas input – could be to put a “label” setting in the block settings/inspector. On-canvas editing is probably preferred, but if this is any easier, it would be a fair middle-ground, imo.

@hypest
Copy link
Contributor

hypest commented Jul 9, 2019

Opened a follow up ticket: #1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants