Fix paragraph splits on the Paragraph block #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
koke
reviewed
Aug 13, 2018
package.json
Outdated
| @@ -45,7 +45,7 @@ | |||
| "pre-build": "yarn check-gb-unused-babelrc && yarn bypass-gb-babel", | |||
| "test:pre-build": "yarn check-gb-unused-babelrc && yarn test:bypass-gb-babel", | |||
| "start": "yarn pre-build && yarn react-native start", | |||
| "start:reset": "yarn clean:runtime && yarn start --reset-cache", | |||
| "start:reset": "yarn clean:metro && yarn start --reset-cache", | |||
There was a problem hiding this comment.
There's #103 which looks like it's also taking care of this. Can you maybe review that one and get it merged? Otherwise, I think there will be a conflict
This reverts commit 8cfefc5.
|
@koke thanks for the heads up! I just reviewed the other PR and reverted the changes on this PR. |
hypest
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Works nicely on my end @SergioEstevao 👍
Feel free to update to the GB hash when the GB side PR is merged and merge here.
# Conflicts: # jest.config.js
hypest
pushed a commit
that referenced
this pull request
Jan 3, 2019
Avoid testing for focus if there is nothing focused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression where inserting multiple lines on a paragraph block was crashing the example app.