Add @-mention support #2163

mchowning · 2020-04-16T15:56:11Z

Fixes #331 by adding an @-button for inserting mentions for any RichText-based block.

Gutenberg PR: WordPress/gutenberg#21651
WPAndroid PR: wordpress-mobile/WordPress-Android#11693
WPiOS PR: wordpress-mobile/WordPress-iOS#13942

Testing

Open any RichText-based block.
Tap the @ button on the far right of the format toolbar
Use the Add Mention UI to select a mention to use.

PR submission checklist:

I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

# Conflicts: # gutenberg

android/app/src/main/java/com/gutenberg/MainApplication.java

# Conflicts: # gutenberg

iamthomasbishop · 2020-04-22T00:01:38Z

@mchowning @SergioEstevao Great work thus far! I've only had a chance to take Android for a spin (Sergio is helping to get me an iOS test build, so I'll test iOS asap). Based on that quick spin, here is some initial feedback. (I hope this is the right issue to drop feedback on — if not, I can move to another ticket!)

Edit: I'm going through and editing my previous comments after testing with iOS, as some of the issues apply only to Android or iOS, and some to both. I've also added a couple of additional items found during this review.

Initial review notes

Both platforms

We should add a separator before the @ button (example)
The @-mention toolbar seems a bit tall (54px?). It should match the height (44px) and styling of the block toolbar (example)
I expected typing @ on the keyboard to trigger the mentions UI
Similar to the last point, after applying a username, I expected to be able to remove some of the username characters to trigger the UI with that string as the active search. For example: if I type something, and then remove characters I expected it to start searching as I delete characters
When the @-mention is applied, we might want to style it like a link, or at least make it visually distinct
Can we add a trailing space to the username when one is applied to the block? I can't think of a scenario that I wouldn't want a space after the username.

Android-only

There is sometimes a weird glitch where the UI sort of flashes momentarily when you're exiting the flow. To reproduce this, open the @-mention UI, don't type anything, tap the empty toolbar to hide the UI, then tap on another block
We can probably get rid of the shadow on mentions UI
Tapping delete when only @ is shown in the input should exit the @-mention UI

iOS-only

Mention toolbar should be styled the same as the block toolbar (top border and same height)
User list should be full-width (seems to be
Tapping outside (above) the user list should exit the @-mention flow (perform same action as tapping on the (x) in the input)
The animation when the UI appears is a bit odd (fades in and expands from the right). It could probably be a subtle fade, and if we apply a expand transition, it can expand upward.
The expanded user list only shows 3 users at most, so it might be useful if a fourth item was hanging over the edge as to hint that you can scroll more. We could also make the list container a little taller, but this would be fine if its more obvious that you can scroll.

Bonus points

This is a bit out of scope, but it would certainly be nice-to-have!

When the list is open all the way to the app bar and you're scrolled to the top of the list, it'd be nice for a swipe-down gesture to dismiss the UI

SergioEstevao · 2020-04-23T09:24:58Z

iOS-only

Mention toolbar should be styled the same as the block toolbar (top border and same height)
User list should be full-width (seems to be
Tapping outside (above) the user list should exit the @-mention flow (perform same action as tapping on the (x) in the input)
The animation when the UI appears is a bit odd (fades in and expands from the right). It could probably be a subtle fade, and if we apply a expand transition, it can expand upward.
The expanded user list only shows 3 users at most, so it might be useful if a fourth item was hanging over the edge as to hint that you can scroll more. We could also make the list container a little taller, but this would be fine if its more obvious that you can scroll.

SergioEstevao · 2020-04-23T09:34:24Z

We should add a separator before the @ button (example)
ok
The @-mention toolbar seems a bit tall (54px?). It should match the height (44px) and styling of the block toolbar (example)

ok

I expected typing @ on the keyboard to trigger the mentions UI

While I understand this is good to have, it will involve a bit more of a technical challenge in terms that we will need to send back and forward from JS to native the keypresses of @

Similar to the last point, after applying a username, I expected to be able to remove some of the username characters to trigger the UI with that string as the active search. For example: if I type something, and then remove characters I expected it to start searching as I delete characters

This is one is even more challenging because for this to work we will need to send all the keypresses between JS and Native, and the performance will suffer because of this.

When the @-mention is applied, we might want to style it like a link, or at least make it visually distinct

Do we have this on the web? If not it will need something to be coordinated with our web colleagues.

Can we add a trailing space to the username when one is applied to the block? I can't think of a scenario that I wouldn't want a space after the username.

Easy to do :)

iamthomasbishop · 2020-04-23T16:56:25Z

@SergioEstevao Thanks for the updates!

While I understand this is good to have, it will involve a bit more of a technical challenge in terms that we will need to send back and forward from JS to native the keypresses of @

Fair enough. It would definitely be nice to have, but if it's a lot of work, it could be part of the next iteration.

This is one is even more challenging because for this to work we will need to send all the keypresses between JS and Native, and the performance will suffer because of this.

Same thing as the last one, although I think this is less important than the previous one.

Do we have this on the web?

No, we don't have this on the web, but this is how it works on most other products and it feels odd that it's not styled as a link considering that's what the front-end output is.

mchowning · 2020-04-23T21:34:01Z

Thanks so much @iamthomasbishop ! Since @SergioEstevao has already responded to the iOS and cross-platform issues (and I agree with everything he said), I'll address the Android-specific issues.

Android-Only

There is sometimes a weird glitch where the UI sort of flashes momentarily when you're exiting the flow. To reproduce this, open the @-mention UI, don't type anything, tap the empty toolbar to hide the UI, then tap on another block

I'm noticing that tapping on the @-mentions toolbar is dismissing the available suggestions while keeping the mentions "screen" open so it shows the "No matching users" text. That is certainly something that needs to be fixed, but it sounds like you are describing a different issue. (◀️ that issue has been fixed)

Can you tell me a bit more about the glitch you're seeing? I'm having trouble recreating it.

We can probably get rid of the shadow on mentions UI

I want to do a bit more digging on this, but it's looking like this will be difficult to change. The suggestions are actually appearing in a pop-up window, which the system applies a shadow to. I'm just disguising the fact that it's a popup window by making it full-width. It feels to me like this is not a must-have if it turns out to be particularly difficult, do you agree?

Tapping delete when only @ is shown in the input should exit the @-mention UI

That makes sense! 👍

# Conflicts: # gutenberg

SergioEstevao · 2020-04-27T15:05:04Z

We should add a separator before the @ button

Done

iamthomasbishop · 2020-04-28T18:31:01Z

@mchowning I forgot to come back to submit my replies to you on Friday, my bad 🤦

issue has been fixed

Awesome!

shadow

I definitely wouldn’t consider it a blocker, but if we can’t remove the shadow altogether, is there a way we can bump up the z-index of the mention toolbar to be above it? In other words, if the suggestions UI is flush against the toolbar, and the toolbar has a higher z-index, it’d cover the shadow.

If that’s not possible, let’s make the UI not-quite full-width — maybe 8 or 16px margin on each side of the suggestions UI?

I’m going to play with an updated iOS build now and report back if I have any additional feedback.

iamthomasbishop · 2020-04-28T18:54:59Z

@SergioEstevao I found a tiny thing on iOS, and I’m not sure where it’s coming from. The background color of the suggestions is different depending on the width of the screen/app. For example, on iPad full-screen, the background looks black, whereas on split-view iPad or iPhone, it looks like a secondary surface material (dark gray). Can we force all breakpoints to use the dark gray? Here are some screenshots:

Full-screen iPad

Split-view iPad

Not a blocker, and this might be better left as a refinement to the native part, but I also noticed the suggestions rows going full-width feels a little odd. I wonder if on wider screens we should either make the container of each suggestion narrower or perhaps stack the username and full name in the rows like Github for iOS does — like this:

mchowning · 2020-04-28T19:29:21Z

As soon as jitpack decides to let the WPAndroid build succeed 😞this will be ready for another review @iamthomasbishop . Here is a summary of where things stand with respect to Android:

Done

Add a separator before @ button
Update height of mention toolbar to 44px
We can probably get rid of the shadow on mentions UI
Tapping delete when only @ is shown in the input should exit the @-mention UI

Not Done on Android

Can we add a trailing space to the username when one is applied to the block? I can't think of a scenario that I wouldn't want a space after the username.

This is working on iOS. At this time I have not made this change on Android, however, because this behavior would be broken currently on Android. The technical issue is that if we think that there is an extra space that the native code might remove we reset the cursor's position. As a result, if the mention ends with a space, the cursor is moved to the beginning of the mention. It seems to me that having the cursor after the just-inserted mention without a space is much less disruptive to the writing flow than having the cursor at the beginning of the mention with a space at the end.

I am working on this, but addressing it will probably require touching code that was added to avoid a number of crashes on Android; I want to work on that change separately from this PR since it looks like it will be high risk and should be reviewed in isolation to make sure I don't introduce any regressions. Also, my thinking is that the lack of a space after the mention is probably not a blocking issue.

There is sometimes a weird glitch where the UI sort of flashes momentarily when you're exiting the flow. To reproduce this, open the @-mention UI, don't type anything, tap the empty toolbar to hide the UI, then tap on another block

I'm not clear on what glitch you're seeing here, could you describe it a bit more or record a video?

Future Improvements

These are things that will require a bit of work to implement (discussed here), and I think we should keep track of them because they would be really good future improvements.

I expected typing @ on the keyboard to trigger the mentions UI
When the @-mention is applied, we might want to style it like a link, or at least make it visually distinct
After applying a username, I expected to be able to remove some of the username characters to trigger the UI with that string as the active search. For example: if I type something, and then remove characters I expected it to start searching as I delete characters
When the list is open all the way to the app bar and you're scrolled to the top of the list, it'd be nice for a swipe-down gesture to dismiss the UI

iamthomasbishop · 2020-04-29T16:32:39Z

@mchowning Just had a chance to review again.

It seems to me that having the cursor after the just-inserted mention without a space is much less disruptive

Agreed — this would be really nice to have, but not adding a space is indeed less disruptive. I don't consider it a pure blocker, but it's close because (imo) it feels like a bug in practice. Addressing in a separate PR is fine.

I'm not clear on what glitch you're seeing here, could you describe it a bit more or record a video?

Sure thing, here's a video. Note: it's happening when I tapped the user from the suggestions list.

Future Improvements

Sounds good 👍

mchowning · 2020-04-30T13:39:32Z

Thanks for the video of the UI glitch @iamthomasbishop ! That wasn't happening on my test device, but I found an emulator that showed the same issue, and it should be resolved now. Would you mind taking a look at the latest installable build with your device to confirm that it's fixed for you as well?

# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/android/raw/i18ncache_data_ar.json # bundle/android/raw/i18ncache_data_bg.json # bundle/android/raw/i18ncache_data_bo.json # bundle/android/raw/i18ncache_data_ca.json # bundle/android/raw/i18ncache_data_cs.json # bundle/android/raw/i18ncache_data_cy.json # bundle/android/raw/i18ncache_data_da.json # bundle/android/raw/i18ncache_data_de.json # bundle/android/raw/i18ncache_data_el.json # bundle/android/raw/i18ncache_data_enau.json # bundle/android/raw/i18ncache_data_enca.json # bundle/android/raw/i18ncache_data_engb.json # bundle/android/raw/i18ncache_data_ennz.json # bundle/android/raw/i18ncache_data_enza.json # bundle/android/raw/i18ncache_data_es.json # bundle/android/raw/i18ncache_data_esar.json # bundle/android/raw/i18ncache_data_escl.json # bundle/android/raw/i18ncache_data_escr.json # bundle/android/raw/i18ncache_data_fa.json # bundle/android/raw/i18ncache_data_fr.json # bundle/android/raw/i18ncache_data_gl.json # bundle/android/raw/i18ncache_data_he.json # bundle/android/raw/i18ncache_data_hr.json # bundle/android/raw/i18ncache_data_hu.json # bundle/android/raw/i18ncache_data_id.json # bundle/android/raw/i18ncache_data_is.json # bundle/android/raw/i18ncache_data_it.json # bundle/android/raw/i18ncache_data_ja.json # bundle/android/raw/i18ncache_data_ka.json # bundle/android/raw/i18ncache_data_ko.json # bundle/android/raw/i18ncache_data_nb.json # bundle/android/raw/i18ncache_data_nl.json # bundle/android/raw/i18ncache_data_nlbe.json # bundle/android/raw/i18ncache_data_pl.json # bundle/android/raw/i18ncache_data_pt.json # bundle/android/raw/i18ncache_data_ptbr.json # bundle/android/raw/i18ncache_data_ro.json # bundle/android/raw/i18ncache_data_ru.json # bundle/android/raw/i18ncache_data_sk.json # bundle/android/raw/i18ncache_data_sq.json # bundle/android/raw/i18ncache_data_sr.json # bundle/android/raw/i18ncache_data_sv.json # bundle/android/raw/i18ncache_data_th.json # bundle/android/raw/i18ncache_data_tr.json # bundle/android/raw/i18ncache_data_uk.json # bundle/android/raw/i18ncache_data_ur.json # bundle/android/raw/i18ncache_data_vi.json # bundle/android/raw/i18ncache_data_zhcn.json # bundle/android/raw/i18ncache_data_zhtw.json # bundle/ios/App.js # bundle/ios/App.js.map # bundle/ios/assets/i18n-cache/data/ar.json # bundle/ios/assets/i18n-cache/data/bg.json # bundle/ios/assets/i18n-cache/data/bo.json # bundle/ios/assets/i18n-cache/data/ca.json # bundle/ios/assets/i18n-cache/data/cs.json # bundle/ios/assets/i18n-cache/data/cy.json # bundle/ios/assets/i18n-cache/data/da.json # bundle/ios/assets/i18n-cache/data/de.json # bundle/ios/assets/i18n-cache/data/el.json # bundle/ios/assets/i18n-cache/data/en-au.json # bundle/ios/assets/i18n-cache/data/en-ca.json # bundle/ios/assets/i18n-cache/data/en-gb.json # bundle/ios/assets/i18n-cache/data/en-nz.json # bundle/ios/assets/i18n-cache/data/en-za.json # bundle/ios/assets/i18n-cache/data/es-ar.json # bundle/ios/assets/i18n-cache/data/es-cl.json # bundle/ios/assets/i18n-cache/data/es-cr.json # bundle/ios/assets/i18n-cache/data/es.json # bundle/ios/assets/i18n-cache/data/fa.json # bundle/ios/assets/i18n-cache/data/fr.json # bundle/ios/assets/i18n-cache/data/gl.json # bundle/ios/assets/i18n-cache/data/he.json # bundle/ios/assets/i18n-cache/data/hr.json # bundle/ios/assets/i18n-cache/data/hu.json # bundle/ios/assets/i18n-cache/data/id.json # bundle/ios/assets/i18n-cache/data/is.json # bundle/ios/assets/i18n-cache/data/it.json # bundle/ios/assets/i18n-cache/data/ja.json # bundle/ios/assets/i18n-cache/data/ka.json # bundle/ios/assets/i18n-cache/data/ko.json # bundle/ios/assets/i18n-cache/data/nb.json # bundle/ios/assets/i18n-cache/data/nl-be.json # bundle/ios/assets/i18n-cache/data/nl.json # bundle/ios/assets/i18n-cache/data/pl.json # bundle/ios/assets/i18n-cache/data/pt-br.json # bundle/ios/assets/i18n-cache/data/pt.json # bundle/ios/assets/i18n-cache/data/ro.json # bundle/ios/assets/i18n-cache/data/ru.json # bundle/ios/assets/i18n-cache/data/sk.json # bundle/ios/assets/i18n-cache/data/sq.json # bundle/ios/assets/i18n-cache/data/sr.json # bundle/ios/assets/i18n-cache/data/sv.json # bundle/ios/assets/i18n-cache/data/th.json # bundle/ios/assets/i18n-cache/data/tr.json # bundle/ios/assets/i18n-cache/data/uk.json # bundle/ios/assets/i18n-cache/data/ur.json # bundle/ios/assets/i18n-cache/data/vi.json # bundle/ios/assets/i18n-cache/data/zh-cn.json # bundle/ios/assets/i18n-cache/data/zh-tw.json # gutenberg

cameronvoell

Looks good. Functionality mostly tested via the WPAndroid App and PR instructions. I did check the iOS example app as well which looks good. 🎉

(edit - minor issue that I think is not a blocker, video on gutenberg PR WordPress/gutenberg#21651 (review))

cameronvoell · 2020-05-08T04:57:12Z

...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java

-                             Application application, boolean isDebug, boolean buildGutenbergFromSource,
-                             String postType, boolean isNewPost, String localeString, Bundle translations,
-                             int colorBackground, boolean isDarkMode) {
+    public void onCreateView(Context initContext,


I can't see any reason to keep this deprecated, overloaded onCreateView. Introduced 09367d3 but I'm not sure it was ever used for anything, maybe just added to be safe in that initial change I linked. But no real need to "refactor" and remove that in combination with this change if there's a small risk it breaks something that I'm just not imagining, could be removed in a future clean up/refactor PR, so up to you.

I had the exact same thought. I was very tempted to just remove it, but ended up deciding not to lump that change in with these changes.

cameronvoell · 2020-05-08T05:06:53Z

ios/gutenberg/GutenbergViewController.swift

@@ -194,6 +195,10 @@ extension GutenbergViewController: GutenbergBridgeDelegate {
    func gutenbergDidLogUserEvent(_ event: GutenbergUserEvent) {
        print("Gutenberg loged user event")
    }
+
+    func gutenbergDidRequestMention(callback: @escaping (Result<String, NSError>) -> Void) {
+        callback(.success("matt"))


I'd be in favor of "sergio" here for balance, but I guess the name "matt" get's special treatment around here ;-P

# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/android/raw/i18ncache_data_ar.json # bundle/android/raw/i18ncache_data_bo.json # bundle/android/raw/i18ncache_data_cs.json # bundle/android/raw/i18ncache_data_fr.json # bundle/android/raw/i18ncache_data_gl.json # bundle/android/raw/i18ncache_data_it.json # bundle/android/raw/i18ncache_data_ko.json # bundle/android/raw/i18ncache_data_nb.json # bundle/android/raw/i18ncache_data_nl.json # bundle/android/raw/i18ncache_data_ro.json # bundle/android/raw/i18ncache_data_ru.json # bundle/android/raw/i18ncache_data_sq.json # bundle/android/raw/i18ncache_data_sv.json # bundle/android/raw/i18ncache_data_tr.json # bundle/ios/App.js # bundle/ios/App.js.map # bundle/ios/assets/i18n-cache/data/ar.json # bundle/ios/assets/i18n-cache/data/bo.json # bundle/ios/assets/i18n-cache/data/cs.json # bundle/ios/assets/i18n-cache/data/fr.json # bundle/ios/assets/i18n-cache/data/gl.json # bundle/ios/assets/i18n-cache/data/it.json # bundle/ios/assets/i18n-cache/data/ko.json # bundle/ios/assets/i18n-cache/data/nb.json # bundle/ios/assets/i18n-cache/data/nl.json # bundle/ios/assets/i18n-cache/data/ro.json # bundle/ios/assets/i18n-cache/data/ru.json # bundle/ios/assets/i18n-cache/data/sq.json # bundle/ios/assets/i18n-cache/data/sv.json # bundle/ios/assets/i18n-cache/data/tr.json # gutenberg

# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg

# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/android/raw/i18ncache_data_de.json # bundle/android/raw/i18ncache_data_pt.json # bundle/android/raw/i18ncache_data_ptbr.json # bundle/android/raw/i18ncache_data_tr.json # bundle/ios/App.js # bundle/ios/App.js.map # bundle/ios/assets/i18n-cache/data/de.json # bundle/ios/assets/i18n-cache/data/pt-br.json # bundle/ios/assets/i18n-cache/data/pt.json # bundle/ios/assets/i18n-cache/data/tr.json # gutenberg

mchowning and others added 4 commits April 16, 2020 11:24

Add empty mention implementation for demo app

82b609f

Update release notes

2cbc40a

Update gutenberg ref

4b76cff

Add stub function for iOS

0d04a82

mchowning requested a review from SergioEstevao April 16, 2020 15:56

Implement delegate method for requesting mentions.

ce88a8a

SergioEstevao self-assigned this Apr 16, 2020

SergioEstevao added this to the 1.27 milestone Apr 16, 2020

SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Apr 16, 2020

Merge branch 'develop' into issue_331/mention_support

a0a3ec5

# Conflicts: # gutenberg

SergioEstevao mentioned this pull request Apr 18, 2020

Issue/implement mentions in gutenberg wordpress-mobile/WordPress-iOS#13942

Merged

3 tasks

mchowning mentioned this pull request Apr 20, 2020

@-mention Activity for Gutenberg wordpress-mobile/WordPress-Android#11693

Merged

3 tasks

mchowning requested a review from ceyhun April 20, 2020 17:17

mchowning marked this pull request as ready for review April 20, 2020 17:19

SergioEstevao reviewed Apr 20, 2020

View reviewed changes

android/app/src/main/java/com/gutenberg/MainApplication.java Outdated Show resolved Hide resolved

SergioEstevao and others added 6 commits April 20, 2020 18:26

Merge branch 'develop' into issue_331/mention_support

fae7dc6

# Conflicts: # gutenberg

User error domain and code information on the promise's rejecter

41dbe0a

Stub demo app to always mention "matt"

8446c5b

Merge branch 'develop' into issue_331/mention_support

db492a3

# Conflicts: # gutenberg

Update GB reference.

7532fb4

Update bundles.

58d372e

Update GB reference.

c06e7b6

SergioEstevao added 3 commits April 23, 2020 23:33

Update GB reference.

411492e

Update bundles.

8eb2c1b

Update GB reference.

65383b8

SergioEstevao added 2 commits April 27, 2020 15:25

Merge branch 'develop' into issue_331/mention_support

5c7bea0

# Conflicts: # gutenberg

Update GB reference.

166cca2

SergioEstevao added 3 commits April 27, 2020 16:22

Update GB reference.

4d923da

Update GB reference.

94cca3d

Update bundles.

f145c1b

Update gutenberg ref

27411aa

mchowning force-pushed the issue_331/mention_support branch from ca7bc3b to 27411aa Compare April 29, 2020 12:59

SergioEstevao marked this pull request as ready for review April 29, 2020 16:26

mchowning mentioned this pull request Apr 30, 2020

RNMobile: Remove willTrimSpacesCheck for Android WordPress/gutenberg#22006

Closed

6 tasks

cameronvoell approved these changes May 8, 2020

View reviewed changes

SergioEstevao added 5 commits May 8, 2020 14:09

Update GB reference.

4a0547e

Update bundles.

7b1cc91

Merge branch 'develop' into issue_331/mention_support

b33bbb0

# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg

Update bundles.

76e43cb

SergioEstevao modified the milestones: 1.28, 1.29 May 13, 2020

SergioEstevao added 4 commits May 20, 2020 00:29

Update GB reference.

db05178

Update GB reference.

a0df91e

Update bundles.

1f5ee28

SergioEstevao merged commit bd44f9a into develop May 20, 2020

SergioEstevao deleted the issue_331/mention_support branch May 20, 2020 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add @-mention support #2163

Add @-mention support #2163

mchowning commented Apr 16, 2020 •

edited

Loading

iamthomasbishop commented Apr 22, 2020 •

edited

Loading

SergioEstevao commented Apr 23, 2020 •

edited

Loading

SergioEstevao commented Apr 23, 2020

iamthomasbishop commented Apr 23, 2020

mchowning commented Apr 23, 2020 •

edited

Loading

SergioEstevao commented Apr 27, 2020

iamthomasbishop commented Apr 28, 2020

iamthomasbishop commented Apr 28, 2020 •

edited

Loading

mchowning commented Apr 28, 2020

iamthomasbishop commented Apr 29, 2020

mchowning commented Apr 30, 2020

cameronvoell left a comment •

edited

Loading

cameronvoell May 8, 2020

mchowning May 8, 2020

cameronvoell May 8, 2020

Add @-mention support #2163

Add @-mention support #2163

Conversation

mchowning commented Apr 16, 2020 • edited Loading

Testing

iamthomasbishop commented Apr 22, 2020 • edited Loading

Initial review notes

Both platforms

Android-only

iOS-only

Bonus points

SergioEstevao commented Apr 23, 2020 • edited Loading

iOS-only

SergioEstevao commented Apr 23, 2020

iamthomasbishop commented Apr 23, 2020

mchowning commented Apr 23, 2020 • edited Loading

Android-Only

SergioEstevao commented Apr 27, 2020

iamthomasbishop commented Apr 28, 2020

iamthomasbishop commented Apr 28, 2020 • edited Loading

mchowning commented Apr 28, 2020

Done

Not Done on Android

Future Improvements

iamthomasbishop commented Apr 29, 2020

mchowning commented Apr 30, 2020

cameronvoell left a comment • edited Loading

Choose a reason for hiding this comment

cameronvoell May 8, 2020

Choose a reason for hiding this comment

mchowning May 8, 2020

Choose a reason for hiding this comment

cameronvoell May 8, 2020

Choose a reason for hiding this comment

mchowning commented Apr 16, 2020 •

edited

Loading

iamthomasbishop commented Apr 22, 2020 •

edited

Loading

SergioEstevao commented Apr 23, 2020 •

edited

Loading

mchowning commented Apr 23, 2020 •

edited

Loading

iamthomasbishop commented Apr 28, 2020 •

edited

Loading

cameronvoell left a comment •

edited

Loading