-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove block top/bottom padding #399
Conversation
Thanks for pinging for review. Unsupported blocks should still maintain that top/bottom padding, so how it was in the "before" examples was proper. Example: Note: each block, regardless of type, has the same padding: 12pt top/bottom, 16pt left/right. I think we should also think about implementing the styling shown here, but that's for a separate issue. |
Updated in 9f21f87, where it's been updated to match that 12dp value for top/bottom for BeforeAfterdoes it look good now @iamthomasbishop ? |
oops! this is fixed then in a1bdd09 results: |
…ding as specified by design
ok - ready for another pass @iamthomasbishop , implemented the specs described in #393 (comment) in 81d9704, this is how it looks like (before/after): |
Merging as agreed |
As discussed in dm, the block inner body padding/margin stuff looks good here, so feel free to 🚢! We can handle this in a separate issue, but the spacings on the inline toolbar (up/down/trash) needs to be slightly tweaked to include a slight (2pt) margin on both left/right edges of the toolbar. This helps to visually align the block content a little better. |
no worries, opened issue here #409 - let's follow discussion there or on upcoming PR |
Fixes #393
Removes the top/bottom padding on
block-container
as it was adding an unneeded extra space.Before:
After:
Before (WPAndroid):
After (WPAndroid):
Before (demo app on iOS):
After (demo app on iOS):