Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jest 28+ #23

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Add support for Jest 28+ #23

merged 2 commits into from
Jan 30, 2023

Commits on Jan 25, 2023

  1. Fix Jest 28+ expect.extend is not a function error (software-mansio…

    …n#3559)
    
    Reanimated is not fully compatible with Jest 28+ even after the PR software-mansion#3347. Using it with Jest 28+ leads to this error:
    
    <img width="796" alt="Ekran Resmi 2022-09-10 15 00 33" src="https://user-images.githubusercontent.com/22980987/189482337-cc2655f6-9463-4a05-9998-5fc3592f5cc0.png">
    
    The reason is, the "expect" module's export approach has changed starting from Jest 28. It used to export the `expect` function directly, as can be seen [here](https://github.com/facebook/jest/blob/v27.5.1/packages/expect/src/index.ts#L441).
    
    This means, requiring the "expect" module like this
    
    ```ts
    const expect = require('expect')
    ```
    
    was providing direct access to the `expect` function alongside with its attached methods, like `extend`.
    
    This has [changed with Jest 28](https://github.com/facebook/jest/blob/v28.0.0/packages/expect/src/index.ts#L449). `export default expect` is the new export statement, which means requiring the "expect" package returns the module object, instead of the function.
    
    software-mansion#3347 PR attempts to fix this error by assuming "expect" package should throw an error with Jest 28 and it can catch that and require the "expect" from the `@jest/globals` package for Jest 28+ project but it's not the case in reality. "expect" package is still shipped with Jest 28, so, requiring it doesn't throw an error as expected in the PR.
    
    By knowing the export difference, I checked if the value of the module is object or not after requiring it. If it's an object, it means user is on Jest 28+ codebase. The rest is the same with the previous PR. I require the "expect" function from `@jest/globals` and use it.
    
    Tested on Jest 29 and Jest 27.5.1
    
    Fixes software-mansion#3553 and software-mansion#3215.
    yusufyildirim authored and Gerardo committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d0009ba View commit details
    Browse the repository at this point in the history
  2. Bump version to 2.9.1-wp-3

    Gerardo committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    455061b View commit details
    Browse the repository at this point in the history