diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e623b44e0..d5b8151055 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ ## Changelog +### Version 5.0.2 +* Fix crash when RCTVideo's superclass doesn't observe the keyPath 'frame' (iOS) [#1720](https://github.com/react-native-community/react-native-video/pull/1720) + ### Version 5.0.1 * Fix AndroidX Support bad merge diff --git a/README.md b/README.md index 35d6a87ed9..9be9cc268e 100644 --- a/README.md +++ b/README.md @@ -59,6 +59,12 @@ Then follow the instructions for your platform to link react-native-video into y #### Standard Method +**React Native 0.60 and above** + +Run `pod install` in the `ios` directory. Linking is not required in React Native 0.60 and above. + +**React Native 0.59 and below** + Run `react-native link react-native-video` to link the react-native-video library. #### Using CocoaPods (required to enable caching) diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java index 7208186680..4a015a027f 100644 --- a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java +++ b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java @@ -2,7 +2,6 @@ import android.annotation.TargetApi; import android.content.Context; -import androidx.core.content.ContextCompat; import android.util.AttributeSet; import android.view.Gravity; import android.view.SurfaceView; @@ -11,6 +10,8 @@ import android.view.ViewGroup; import android.widget.FrameLayout; +import androidx.core.content.ContextCompat; + import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.ExoPlaybackException; import com.google.android.exoplayer2.ExoPlayer; diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m index 4710afaa5a..98cb0737e0 100644 --- a/ios/Video/RCTVideo.m +++ b/ios/Video/RCTVideo.m @@ -712,8 +712,6 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N return; } - } else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) { - [super observeValueForKeyPath:keyPath ofObject:object change:change context:context]; } } diff --git a/package.json b/package.json index 7248580eb0..0618c74eab 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-video", - "version": "5.0.1", + "version": "5.0.2", "description": "A