Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ios_codefreeze_prechecks and other pre-check lanes #576

Closed
mokagio opened this issue Jul 26, 2024 · 2 comments · Fixed by #577
Closed

Deprecate ios_codefreeze_prechecks and other pre-check lanes #576

mokagio opened this issue Jul 26, 2024 · 2 comments · Fixed by #577

Comments

@mokagio
Copy link
Contributor

mokagio commented Jul 26, 2024

I've started looking at the various Simplenote apps release automation with the goal to update then and eventually support releases in CI.

Internal ref p2XJRt-3Ju-p2

One thing I just noticed is the ios_codefreeze_prechecks in Simplenote iOS.

I'm not sure if we explicitly discussed this (a search for issues with "prechecks" brought no results) but I think we have decided to move on from this approach in favor of a more granular and explicit approach, where each project performs the checks it requires.

For example, WordPress iOS individually checks for the git status being clean then switches to trunk if necessary.

We could add the deprecated annotation to the lanes and then remove them whenever we'll ship a new major version.

@spencertransier
Copy link
Contributor

Heh, I actually just started work on deprecating those today 😄 . The discussion to deprecate those got wrapped up in the versioning changes last fall. It was decided to not update the precheck actions for the versioning changes and instead add the actions and steps that used to be performed by the precheck actions into the repos themselves, for better clarity.

@spencertransier
Copy link
Contributor

@mokagio here's the PR for the deprecations: #577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants