Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos on Template #20

Closed
danielgils opened this issue Jul 21, 2023 · 2 comments · Fixed by #24
Closed

Typos on Template #20

danielgils opened this issue Jul 21, 2023 · 2 comments · Fixed by #24
Assignees
@g4brielvs
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v2024.06

Comments

@danielgils
Copy link

Typos on section 2.1:

  • It says "Pyhton API wrapper class created to faciliate the usage of the [...]".
  • It says: "Note that contrary to the previous example, the method expets a list of country names and converts them [...]".
    Typos on section 3.1:
  • It says "Please note that .env must never be commited/versioned (for example, to GitHub) and should [be] ignored on .gitignore."
@g4brielvs
Copy link
Contributor

g4brielvs commented Jul 21, 2023 •
edited
Loading

@danielgils Thanks you so much for contributing to the template. Would you be interested in submitting PR for this?

@g4brielvs g4brielvs added the bug Something isn't working label Jul 21, 2023
@g4brielvs g4brielvs moved this to In Progress in WB Project Templates Jul 21, 2023
@g4brielvs g4brielvs moved this from In Progress to Todo in WB Project Templates Jul 21, 2023
@g4brielvs g4brielvs added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 7, 2023
@g4brielvs g4brielvs self-assigned this Sep 7, 2023
@g4brielvs g4brielvs added this to the v0.2 milestone Sep 7, 2023
@g4brielvs g4brielvs mentioned this issue Sep 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in WB Project Templates Sep 7, 2023
@g4brielvs
Copy link
Contributor

g4brielvs commented Sep 7, 2023 •
edited
Loading

@danielgils Thank you so much for your contribution 🙏! The PR #24 shoudl fix the typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g4brielvs g4brielvs

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
WB Project Templates
Status: Done
Milestone
v2024.06
Development

Successfully merging a pull request may close this issue.

Fix typos worldbank/template
2 participants
@g4brielvs @danielgils