Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework Review Week 1 #1

Open
rohni opened this issue May 3, 2018 · 0 comments
Open

Homework Review Week 1 #1

rohni opened this issue May 3, 2018 · 0 comments

Comments

@rohni
Copy link

rohni commented May 3, 2018

Hi Wouter,
Nice work. Everything works and no eslint errors. The code is clear and easy to read.
Good work!
Below are some points I ran into while going through each file.
step1.js

  • impressive number of languages. ;-)
    step4.js
  • you are missing the second part of the exercise. Did you forget to push it? You are supposed to assign a new string value to the variable and then repeat the first two steps with this new value.
    step5.js
  • I would use the variable values rather than hard-coding the numbers in again.
    i.e. console.log(Math.max(z, a));
    rather than console.log(Math.max(7.25, 7));
    step6.js
  • You logged what you thought the value of the empty array would be, but not what it actually is
  • You did not log the animal array before adding the pig.
    step8.js
  • let carBrand = ['bmw', ' volvo', 'toyota']; because it is an array (i.e. a collection of values) you should give it a plural name. e.g. carBrands
  • for bonus marks: You could have included the two values for the "not same type" statements. 😄
    step10.js
  • While there are no greater or lesser values of infinity (well actually in discrete mathematics there are, but that is not handled by the javascript interpreter. 😉 ), you can compare whether two infinities are equal, and in javascript they are considered equal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant