Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard dependency on internal TomCrypt #1

Open
danielsreichenbach opened this issue Jan 3, 2024 · 0 comments
Open

Remove hard dependency on internal TomCrypt #1

danielsreichenbach opened this issue Jan 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@danielsreichenbach
Copy link
Member

danielsreichenbach commented Jan 3, 2024 •
edited
Loading

Issue

StormLib currently ships with it's own vendored version of libtomcrypt. It does so because it is using a specific function of this dependency for verification of weak digital signatures contained in MPQ archives.

Why is this an issue?

It can not be built against a self-managed version of libtomcrypt, e.g. the official packages in vcpkg for Windows, Homebrew on macOS, or on Debian/Ubuntu.

This is generally considered bad practice.
@danielsreichenbach danielsreichenbach added documentation Improvements or additions to documentation bug Something isn't working and removed documentation Improvements or additions to documentation labels Jan 3, 2024
@danielsreichenbach danielsreichenbach changed the title Assessment of StormLib Remove hard dependency on internal TomCrypt Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielsreichenbach