Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update of multiple quantities in cart in a single mutation #94

Closed
mlipscombe opened this issue Jun 26, 2019 · 1 comment
Closed
Assignees
Labels
design notes Blueprint and notes for coming feature enhancement New feature or request
Milestone

Comments

@mlipscombe
Copy link

Is your feature request related to a problem? Please describe.
Currently, only a single CartItem can be updated at a time when calling updateItemQuantity. Given that it's a common operation to have a list of quantities and an "update cart" button on a shopping cart page, this is awkward.

Describe the solution you'd like
updateItemQuantity, or a new mutation like updateItemQuantities, should accept an array of CartItem keys and quantities, to allow for updating the cart quantities in a single mutation.

Describe alternatives you've considered
Multiple top level mutations, but this is really awkward in Apollo -- for example, using the <Mutation> component is a non-starter, and additional code is needed to generate multiple named mutations and then parse the results.

@kidunot89
Copy link
Member

I have considered this, but haven't gone far beyond that. I do think is it's necessary however and will add an updateItemQuantities mutation in the next release.

@kidunot89 kidunot89 mentioned this issue Jul 1, 2019
18 tasks
@kidunot89 kidunot89 added enhancement New feature or request design notes Blueprint and notes for coming feature labels Jul 1, 2019
@kidunot89 kidunot89 added this to the v0.2.0 milestone Jul 1, 2019
@kidunot89 kidunot89 self-assigned this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design notes Blueprint and notes for coming feature enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants