Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore comments deleted when deleting parent post #652

Closed
frankiejarrett opened this issue Oct 15, 2014 · 0 comments · Fixed by #653
Closed

Ignore comments deleted when deleting parent post #652

frankiejarrett opened this issue Oct 15, 2014 · 0 comments · Fixed by #653
Labels
performance requirement

Comments

@frankiejarrett
Copy link
Contributor

We noticed a very large number of records coming flooding in from a certain site all relating to comments being deleted, but they weren't system actions, it was being done by a real user.

It turns out that when you permanently delete a post it also permanently deletes the comments on that post and attributes you as the one who deleted them.

This means that deleting 1 post that has 100,000 comments on it would result in 100,001 Stream records created. 😸

We need to ignore comment deletion in these cases and perhaps find a way to say how many comments were deleted inside 1 record. Such as: 2,000 comments deleted from "Hello, world"

/cc @lukecarbis @shadyvb

screen shot 2014-10-15 at 12 12 17 pm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent comment delete records when caused by a post delete xwp/stream
2 participants
@frankiejarrett @lukecarbis