Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require opt-in for comment flood tracking #656

Closed
frankiejarrett opened this issue Nov 12, 2014 · 0 comments · Fixed by #657
Closed

Require opt-in for comment flood tracking #656

frankiejarrett opened this issue Nov 12, 2014 · 0 comments · Fixed by #657

Comments

@frankiejarrett
Copy link
Contributor

Up to this point, Stream has been creating a record each time Comment flooding is prevented. That is to say, when WordPress prevents a user from posting duplicate comments.

When WordPress prevents comment flooding, it's preventing the comment from entering the database.

Although this is somewhat nice information to know, tracking it actually falls outside the scope of Stream's purpose, which is to only track changes to the database (see #547 for a related discussion on this topic).

Tracking comment flooding actually isn't a smart idea for the majority of sites because it ends up creating a flood of Stream records which then drown out the important records dealing with actual database changes.

On my personal site, comment flood records accounted for 36% of all records. Knowing that WordPress prevented flooding is not worth 36% of real estate in my Stream data.

The point of preventing comment flooding is to minimize noise in the WP Admin area by weeding out superfluous comments. Stream should not be adding noise by tracking this behavior by default.

This callback should be opt-in only, similarly to what was done in #649.

@frankiejarrett frankiejarrett changed the title Require opt-in for comment flooding tracking Require opt-in for comment flood tracking Nov 13, 2014
@frankiejarrett frankiejarrett self-assigned this Nov 14, 2014
@frankiejarrett frankiejarrett removed their assignment Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant