Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow properties with zero values to be included in queries #698

Closed
frankiejarrett opened this issue Feb 3, 2015 · 0 comments · Fixed by #699
Closed

Allow properties with zero values to be included in queries #698

frankiejarrett opened this issue Feb 3, 2015 · 0 comments · Fixed by #699
Labels

Comments

@frankiejarrett
Copy link
Contributor

We are currently disallowing properties with empty values from being included in the final query array.

This is a problem if you want to query something with an ID of zero, such as a user_id.

We should adjust our definition of what an "empty" property is when building the final query.

Disallowed values

  • NULL
  • bool(false)
  • string(0) "" (an empty string)
  • array(0) {} (an empty array)

Allowed values

  • string(1) "0"
  • int(0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant