Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should store GitHub host pubkey in container instead of insecurely fetching through the network #22

Open
bwbuchanan opened this issue Aug 27, 2023 · 0 comments

Comments

@bwbuchanan
Copy link

This container currently uses ssh-keyscan to fetch the host key for the WP Engine SSH server before attempting to connect.

This is insecure and defeats the entire purpose of having a host key to authenticate the server.

I suggest that instead you hardcode WP Engine's SSH host public key(s) into the container, so that SSH will fail if someone is performing a man-in-the-middle-attack against the connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant