You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current JSON implementation in wpiutil is based on a very old version of nlohmann JSON with lots of customizations to reduce compile time overhead (untemplating, using LLVM containers, moving a lot of code out of line). This should be updated to the most recent version. Ideally it would also use upstream_utils, but this is likely quite difficult due to the number of customizations.
The text was updated successfully, but these errors were encountered:
PeterJohnson
changed the title
Update json implementation
[wpiutil] Update json implementation
Nov 30, 2022
On Ubuntu 2023.04 with gcc 12.2, the JsonComparisonTypesTest Less test fails. It passes if gcc is downgraded to GCC 11.3. This appears to have been fixed upstream in nlohmann/json#3446
The current JSON implementation in wpiutil is based on a very old version of nlohmann JSON with lots of customizations to reduce compile time overhead (untemplating, using LLVM containers, moving a lot of code out of line). This should be updated to the most recent version. Ideally it would also use upstream_utils, but this is likely quite difficult due to the number of customizations.
The text was updated successfully, but these errors were encountered: