Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpiutil] Update json implementation #4739

Closed
PeterJohnson opened this issue Nov 30, 2022 · 2 comments
Closed

[wpiutil] Update json implementation #4739

PeterJohnson opened this issue Nov 30, 2022 · 2 comments
Labels
build Monorepo organization, gradle/cmake, upstream_utils, etc component: wpiutil WPI utility library

Comments

@PeterJohnson
Copy link
Member

The current JSON implementation in wpiutil is based on a very old version of nlohmann JSON with lots of customizations to reduce compile time overhead (untemplating, using LLVM containers, moving a lot of code out of line). This should be updated to the most recent version. Ideally it would also use upstream_utils, but this is likely quite difficult due to the number of customizations.

@PeterJohnson PeterJohnson changed the title Update json implementation [wpiutil] Update json implementation Nov 30, 2022
@Starlight220 Starlight220 added the build Monorepo organization, gradle/cmake, upstream_utils, etc label Nov 30, 2022
@PeterJohnson PeterJohnson added the component: wpiutil WPI utility library label Nov 30, 2022
@sciencewhiz
Copy link
Contributor

On Ubuntu 2023.04 with gcc 12.2, the JsonComparisonTypesTest Less test fails. It passes if gcc is downgraded to GCC 11.3. This appears to have been fixed upstream in nlohmann/json#3446

@PeterJohnson
Copy link
Member Author

Fixed by #5680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Monorepo organization, gradle/cmake, upstream_utils, etc component: wpiutil WPI utility library
Projects
None yet
Development

No branches or pull requests

3 participants