Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos with cspell #6972

Merged
merged 4 commits into from
Aug 17, 2024
Merged

Fix typos with cspell #6972

merged 4 commits into from
Aug 17, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Aug 16, 2024

No description provided.

@Gold856 Gold856 requested review from PeterJohnson and a team as code owners August 16, 2024 02:42
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@Gold856
Copy link
Contributor Author

Gold856 commented Aug 16, 2024

/format

@sciencewhiz
Copy link
Contributor

How much manual clean-up did you have to do? Some of those fixes are fairly impressive.

@Gold856
Copy link
Contributor Author

Gold856 commented Aug 16, 2024

I used cspell only to find mistakes. I manually evaluated every "mistake" it found to determine whether or not to fix it. I ended up having to add several exclusions to make it easier to filter because cspell kept tripping up on things like Unicode characters from wpimath, combined words in the examples, or several other FRC/control terms. I know you've PRed a few typo fixes in the past, so if you have any exclusion lists/settings, I'd love to see them!

@sciencewhiz
Copy link
Contributor

I primarily use misspell because I'm lazy, and it's designed to be conservative. It only checks against a limited dictionary of common misspellings. I've also used codespell which had a reasonable number of things to sift through.

@PeterJohnson PeterJohnson merged commit b12b83a into wpilibsuite:main Aug 17, 2024
33 checks passed
@Gold856 Gold856 deleted the fix-typos branch August 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants