From 2941072dfa004017555def1b59bc4eee16f74230 Mon Sep 17 00:00:00 2001 From: Itay Ziv Date: Tue, 29 Mar 2022 20:29:53 +0300 Subject: [PATCH] Make changes according to review --- sphinxext/opengraph/__init__.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sphinxext/opengraph/__init__.py b/sphinxext/opengraph/__init__.py index 373436a..e955b22 100644 --- a/sphinxext/opengraph/__init__.py +++ b/sphinxext/opengraph/__init__.py @@ -128,6 +128,8 @@ def get_tags( ): image_url = first_image["uri"] ogp_image_alt = first_image.get("alt", None) + else: + first_image = None if image_url: # temporarily disable relative image paths with field lists @@ -137,7 +139,7 @@ def get_tags( # Relative image path detected, relative to the source. Make absolute. if first_image: root = page_url - else: + else: # ogp_image is set # ogp_image is defined as being relative to the site root. # This workaround is to keep that functionality from breaking. root = config["ogp_site_url"]